Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

refactor($parse): remove dead code #9489

Closed
wants to merge 1 commit into from

Conversation

jbedard
Copy link
Collaborator

@jbedard jbedard commented Oct 8, 2014

These operators appear to have never actually been supported. This will have one minor side effect where parsing expressions containing ^ and & operators will now throw from the lexer ($parse/lexerr) instead of parser ($parse/syntax).

@lgalfaso
Copy link
Contributor

lgalfaso commented Oct 8, 2014

this is a breaking change and should be presented as such

@jbedard
Copy link
Collaborator Author

jbedard commented Oct 8, 2014

The change in error codes would essentially only be seen if someone has a typo in their expression. That counts as breaking? :(

@lgalfaso
Copy link
Contributor

lgalfaso commented Oct 8, 2014

ah, you are right. Misread the patch

LGTM

@jeffbcross jeffbcross force-pushed the master branch 2 times, most recently from abdaab7 to 30996f8 Compare October 8, 2014 19:47
@tbosch tbosch self-assigned this Oct 9, 2014
@tbosch
Copy link
Contributor

tbosch commented Oct 9, 2014

Thanks!

@tbosch tbosch closed this in b0307a3 Oct 9, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants