Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix($rootScope.$on) check listener existense while deregistering #9667

Closed
wants to merge 1 commit into from
Closed

fix($rootScope.$on) check listener existense while deregistering #9667

wants to merge 1 commit into from

Conversation

dmytroyarmak
Copy link
Contributor

Check that listener is still present in $$listeners before decrease
$$listenerCount. It fixes problem with incorrect $$listenerCount after
call deregistering function multiple times.

Closes #9666

Check that listener is still present in $$listeners before decrease
$$listenerCount. It fixes problem with incorrect $$listenerCount after
call deregistering function multiple times.

Closes #9666
@petebacondarwin
Copy link
Contributor

LGTM

@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@dmytroyarmak
Copy link
Contributor Author

Sorry, now it should be signed.

@mary-poppins
Copy link

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

petebacondarwin added a commit that referenced this pull request Oct 19, 2014
Check that listener is still present in $$listeners before decrease
$$listenerCount. It fixes problem with incorrect $$listenerCount after
call deregistering function multiple times.

Closes #9666
Closes #9667
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect behavior of deregistration function returned from $rootScope.$on when called twice
3 participants