Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

style: disallow space after object keys, other rules #9679

Closed
wants to merge 1 commit into from
Closed

style: disallow space after object keys, other rules #9679

wants to merge 1 commit into from

Conversation

hzoo
Copy link
Contributor

@hzoo hzoo commented Oct 19, 2014

add disallowSpaceAfterObjectKeys and associated changes.

add disallowMixedSpacesAndTabs (no files changed)
add disallowMultipleLineStrings (no files changed)
add disallowNewlineBeforeBlockStatements (no files changed)

Feel free to remove the other rules if not needed.

cc: @caitp

add `disallowSpaceAfterObjectKeys` and associated changes.
add `disallowMixedSpacesAndTabs` (no files changed)
add `disallowMultipleLineStrings` (no files changed)
@petebacondarwin
Copy link
Contributor

@eltacodeldiablo - thanks for this. I am going to merge. I know you bundled a couple of rules together into a single PR which is fine.
But how about a single commit within the PR for each rule, even if they are trivial. Then we could easily pick one rule and not another and more easily see what files are affected by each rule.

@hzoo
Copy link
Contributor Author

hzoo commented Oct 19, 2014

Ok yeah, a commit for each rule makes sense.

@hzoo hzoo deleted the add-jscs-disallow-space-after-object-keys branch October 19, 2014 21:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants