refactor: remove event faking apis from public api (#17382)

Moves the event faking APIs into `cdk/private/testing` in order to avoid exposing them in the public API of `cdk/testing`.

Resolves COMP-239.

Author: crisbeto

src/cdk-experimental/dialog/BUILD.bazel

@@ -39,7 +39,7 @@ ng_test_library(
         "//src/cdk/bidi",
         "//src/cdk/keycodes",
         "//src/cdk/overlay",
-        "//src/cdk/testing",
+        "//src/cdk/testing/private",
         "@npm//@angular/common",
         "@npm//@angular/platform-browser",
     ],

src/cdk-experimental/dialog/dialog.spec.ts

@@ -26,7 +26,11 @@ import {Directionality} from '@angular/cdk/bidi';
 import {CdkDialogContainer} from './dialog-container';
 import {OverlayContainer} from '@angular/cdk/overlay';
 import {A, ESCAPE} from '@angular/cdk/keycodes';
-import {dispatchKeyboardEvent, createKeyboardEvent, dispatchEvent} from '@angular/cdk/testing';
+import {
+  dispatchKeyboardEvent,
+  createKeyboardEvent,
+  dispatchEvent,
+} from '@angular/cdk/testing/private';
 import {DIALOG_DATA, Dialog, DialogModule, DialogRef} from './index';
 
 describe('Dialog', () => {

src/cdk-experimental/popover-edit/BUILD.bazel

@@ -36,7 +36,7 @@ ng_test_library(
         "//src/cdk/keycodes",
         "//src/cdk/overlay",
         "//src/cdk/table",
-        "//src/cdk/testing",
+        "//src/cdk/testing/private",
         "@npm//@angular/common",
         "@npm//@angular/forms",
         "@npm//rxjs",

src/cdk-experimental/popover-edit/popover-edit.spec.ts

@@ -1,7 +1,7 @@
 import {DataSource} from '@angular/cdk/collections';
 import {LEFT_ARROW, UP_ARROW, RIGHT_ARROW, DOWN_ARROW, TAB} from '@angular/cdk/keycodes';
 import {CdkTableModule} from '@angular/cdk/table';
-import {dispatchKeyboardEvent} from '@angular/cdk/testing';
+import {dispatchKeyboardEvent} from '@angular/cdk/testing/private';
 import {CommonModule} from '@angular/common';
 import {Component, Directive, ElementRef, Type, ViewChild} from '@angular/core';
 import {ComponentFixture, fakeAsync, flush, TestBed, tick, inject} from '@angular/core/testing';

src/cdk-experimental/scrolling/BUILD.bazel

@@ -40,14 +40,14 @@ ng_e2e_test_library(
     name = "e2e_test_sources",
     srcs = glob(["**/*.e2e.spec.ts"]),
     deps = [
-        "//src/cdk/private/testing/e2e",
+        "//src/cdk/testing/private/e2e",
     ],
 )
 
 e2e_test_suite(
     name = "e2e_tests",
     deps = [
         ":e2e_test_sources",
-        "//src/cdk/private/testing/e2e",
+        "//src/cdk/testing/private/e2e",
     ],
 )

src/cdk-experimental/tsconfig-tests.json

@@ -9,7 +9,7 @@
     "target": "es5",
     "types": ["jasmine"],
     "paths": {
-      "@angular/cdk/*": ["../../dist/packages/cdk/*/public-api"],
+      "@angular/cdk/*": ["../../dist/packages/cdk/*"],
       "@angular/cdk-experimental/*": ["./*"]
     }
   },

src/cdk/a11y/BUILD.bazel

@@ -50,7 +50,7 @@ ng_test_library(
         "//src/cdk/keycodes",
         "//src/cdk/observers",
         "//src/cdk/platform",
-        "//src/cdk/testing",
+        "//src/cdk/testing/private",
         "@npm//@angular/platform-browser",
         "@npm//rxjs",
     ],

src/cdk/a11y/focus-monitor/focus-monitor.spec.ts

@@ -4,7 +4,7 @@ import {
   dispatchKeyboardEvent,
   dispatchMouseEvent,
   patchElementFocus,
-} from '@angular/cdk/testing';
+} from '@angular/cdk/testing/private';
 import {Component, NgZone} from '@angular/core';
 import {ComponentFixture, fakeAsync, flush, inject, TestBed, tick} from '@angular/core/testing';
 import {By} from '@angular/platform-browser';

src/cdk/a11y/key-manager/list-key-manager.spec.ts

@@ -1,5 +1,5 @@
 import {DOWN_ARROW, LEFT_ARROW, RIGHT_ARROW, TAB, UP_ARROW} from '@angular/cdk/keycodes';
-import {createKeyboardEvent} from '@angular/cdk/testing';
+import {createKeyboardEvent} from '@angular/cdk/testing/private';
 import {QueryList} from '@angular/core';
 import {fakeAsync, tick} from '@angular/core/testing';
 import {Subject} from 'rxjs';

src/cdk/drag-drop/BUILD.bazel

@@ -37,7 +37,7 @@ ng_test_library(
         "//src/cdk/bidi",
         "//src/cdk/platform",
         "//src/cdk/scrolling",
-        "//src/cdk/testing",
+        "//src/cdk/testing/private",
         "@npm//@angular/common",
         "@npm//rxjs",
     ],

src/cdk/drag-drop/directives/drag.spec.ts

@@ -6,7 +6,7 @@ import {
   dispatchMouseEvent,
   dispatchTouchEvent,
   dispatchFakeEvent,
-} from '@angular/cdk/testing';
+} from '@angular/cdk/testing/private';
 import {
   AfterViewInit,
   ChangeDetectionStrategy,

src/cdk/drag-drop/drag-drop-registry.spec.ts

@@ -6,7 +6,7 @@ import {
   createTouchEvent,
   dispatchTouchEvent,
   dispatchFakeEvent,
-} from '@angular/cdk/testing';
+} from '@angular/cdk/testing/private';
 import {DragDropRegistry} from './drag-drop-registry';
 import {DragDropModule} from './drag-drop-module';
 import {CdkDrag} from './directives/drag';

src/cdk/keycodes/BUILD.bazel

@@ -24,7 +24,7 @@ ts_library(
     ),
     deps = [
         ":keycodes",
-        "//src/cdk/testing",
+        "//src/cdk/testing/private",
         "@npm//@types/jasmine",
     ],
 )

src/cdk/keycodes/modifiers.spec.ts

@@ -1,4 +1,4 @@
-import {createKeyboardEvent} from '@angular/cdk/testing';
+import {createKeyboardEvent} from '@angular/cdk/testing/private';
 import {hasModifierKey} from './modifiers';
 
 describe('keyboard modifiers', () => {

src/cdk/overlay/BUILD.bazel

@@ -55,9 +55,8 @@ ng_test_library(
         "//src/cdk/keycodes",
         "//src/cdk/platform",
         "//src/cdk/portal",
-        "//src/cdk/private/testing",
         "//src/cdk/scrolling",
-        "//src/cdk/testing",
+        "//src/cdk/testing/private",
         "@npm//@angular/common",
         "@npm//@angular/platform-browser",
         "@npm//rxjs",
@@ -74,15 +73,15 @@ ng_e2e_test_library(
     name = "e2e_test_sources",
     srcs = glob(["**/*.e2e.spec.ts"]),
     deps = [
-        "//src/cdk/private/testing/e2e",
+        "//src/cdk/testing/private/e2e",
     ],
 )
 
 e2e_test_suite(
     name = "e2e_tests",
     deps = [
         ":e2e_test_sources",
-        "//src/cdk/private/testing/e2e",
+        "//src/cdk/testing/private/e2e",
     ],
 )
 

src/cdk/overlay/keyboard/overlay-keyboard-dispatcher.spec.ts

@@ -1,5 +1,5 @@
 import {TestBed, inject} from '@angular/core/testing';
-import {dispatchKeyboardEvent} from '@angular/cdk/testing';
+import {dispatchKeyboardEvent} from '@angular/cdk/testing/private';
 import {ESCAPE} from '@angular/cdk/keycodes';
 import {Component, NgModule} from '@angular/core';
 import {OverlayModule, OverlayContainer, Overlay} from '../index';

src/cdk/overlay/overlay-directives.spec.ts

@@ -2,7 +2,11 @@ import {Component, ViewChild} from '@angular/core';
 import {By} from '@angular/platform-browser';
 import {ComponentFixture, TestBed, async, inject, fakeAsync, tick} from '@angular/core/testing';
 import {Directionality} from '@angular/cdk/bidi';
-import {dispatchKeyboardEvent, createKeyboardEvent, dispatchEvent} from '@angular/cdk/testing';
+import {
+  dispatchKeyboardEvent,
+  createKeyboardEvent,
+  dispatchEvent,
+} from '@angular/cdk/testing/private';
 import {ESCAPE, A} from '@angular/cdk/keycodes';
 import {CdkConnectedOverlay, OverlayModule, CdkOverlayOrigin} from './index';
 import {OverlayContainer} from './overlay-container';

src/cdk/overlay/overlay.spec.ts

@@ -10,8 +10,7 @@ import {
   NgZone,
 } from '@angular/core';
 import {Direction, Directionality} from '@angular/cdk/bidi';
-import {MockNgZone} from '@angular/cdk/private/testing';
-import {dispatchFakeEvent} from '@angular/cdk/testing';
+import {MockNgZone, dispatchFakeEvent} from '@angular/cdk/testing/private';
 import {
   ComponentPortal,
   PortalModule,

src/cdk/overlay/position/connected-position-strategy.spec.ts

@@ -1,6 +1,6 @@
 import {ComponentPortal, PortalModule} from '@angular/cdk/portal';
 import {CdkScrollable, ScrollingModule} from '@angular/cdk/scrolling';
-import {MockNgZone} from '@angular/cdk/private/testing';
+import {MockNgZone} from '@angular/cdk/testing/private';
 import {Component, ElementRef, NgModule, NgZone} from '@angular/core';
 import {inject, TestBed} from '@angular/core/testing';
 import {Subscription} from 'rxjs';

src/cdk/overlay/position/flexible-connected-position-strategy.spec.ts

@@ -1,6 +1,6 @@
 import {ComponentPortal, PortalModule} from '@angular/cdk/portal';
 import {CdkScrollable, ScrollingModule, ViewportRuler} from '@angular/cdk/scrolling';
-import {MockNgZone} from '@angular/cdk/private/testing';
+import {MockNgZone} from '@angular/cdk/testing/private';
 import {Component, ElementRef, NgModule, NgZone} from '@angular/core';
 import {inject, TestBed} from '@angular/core/testing';
 import {Subscription} from 'rxjs';

src/cdk/overlay/position/global-position-strategy.spec.ts

@@ -1,6 +1,6 @@
 import {NgModule, NgZone, Component} from '@angular/core';
 import {TestBed, inject} from '@angular/core/testing';
-import {MockNgZone} from '@angular/cdk/private/testing';
+import {MockNgZone} from '@angular/cdk/testing/private';
 import {PortalModule, ComponentPortal} from '@angular/cdk/portal';
 import {OverlayModule, Overlay, OverlayConfig, OverlayRef, OverlayContainer} from '../index';
 

src/cdk/overlay/scroll/block-scroll-strategy.e2e.spec.ts

@@ -1,5 +1,5 @@
 import {browser, Key, element, by} from 'protractor';
-import {getScrollPosition} from '@angular/cdk/private/testing/e2e';
+import {getScrollPosition} from '@angular/cdk/testing/private/e2e';
 
 
 describe('scroll blocking', () => {

src/cdk/private/testing/BUILD.bazel

@@ -43,7 +43,7 @@ ng_test_library(
         ":scrolling",
         "//src/cdk/bidi",
         "//src/cdk/collections",
-        "//src/cdk/testing",
+        "//src/cdk/testing/private",
         "@npm//rxjs",
     ],
 )

src/cdk/scrolling/BUILD.bazel

@@ -1,7 +1,7 @@
 import {inject, TestBed, async, fakeAsync, ComponentFixture, tick} from '@angular/core/testing';
 import {NgModule, Component, ViewChild, ElementRef} from '@angular/core';
 import {CdkScrollable, ScrollDispatcher, ScrollingModule} from './public-api';
-import {dispatchFakeEvent} from '@angular/cdk/testing';
+import {dispatchFakeEvent} from '@angular/cdk/testing/private';
 
 describe('ScrollDispatcher', () => {
 

src/cdk/scrolling/scroll-dispatcher.spec.ts

@@ -1,7 +1,7 @@
 import {TestBed, inject, fakeAsync, tick} from '@angular/core/testing';
 import {ScrollingModule} from './public-api';
 import {ViewportRuler} from './viewport-ruler';
-import {dispatchFakeEvent} from '@angular/cdk/testing';
+import {dispatchFakeEvent} from '@angular/cdk/testing/private';
 import {NgZone} from '@angular/core';
 
 // For all tests, we assume the browser window is 1024x786 (outerWidth x outerHeight).

src/cdk/scrolling/viewport-ruler.spec.ts

@@ -5,7 +5,7 @@ import {
   ScrollDispatcher,
   ScrollingModule
 } from '@angular/cdk/scrolling';
-import {dispatchFakeEvent} from '@angular/cdk/testing';
+import {dispatchFakeEvent} from '@angular/cdk/testing/private';
 import {
   Component,
   Input,

src/cdk/scrolling/virtual-scroll-viewport.spec.ts

@@ -0,0 +1,14 @@
+/**
+ * @license
+ * Copyright Google LLC All Rights Reserved.
+ *
+ * Use of this source code is governed by an MIT-style license that can be
+ * found in the LICENSE file at https://angular.io/license
+ */
+
+// These are private APIs that are used both by the public APIs inside of this package, as well as
+// in the unit tests of other packages, hence why we need to re-export them through here.
+export * from './dispatch-events';
+export * from './event-objects';
+export * from './element-focus';
+export * from './type-in-element';

src/cdk/testing/dispatch-events.ts renamed to src/cdk/testing/fake-events/dispatch-events.ts

@@ -15,8 +15,8 @@ import {ModifierKeys} from './event-objects';
  * @docs-private
  */
 export function isTextInput(element: Element): element is HTMLInputElement | HTMLTextAreaElement {
-  return element.nodeName.toLowerCase() === 'input' ||
-      element.nodeName.toLowerCase() === 'textarea' ;
+  const nodeName = element.nodeName.toLowerCase();
+  return nodeName === 'input' || nodeName === 'textarea' ;
 }
 
 /**

src/cdk/testing/element-focus.ts renamed to src/cdk/testing/fake-events/element-focus.ts

@@ -0,0 +1,17 @@
+package(default_visibility = ["//visibility:public"])
+
+load("//tools:defaults.bzl", "ts_library")
+
+ts_library(
+    name = "private",
+    srcs = glob(
+        ["**/*.ts"],
+        exclude = ["**/*.spec.ts"],
+    ),
+    module_name = "@angular/cdk/testing/private",
+    deps = [
+        "//src/cdk/testing",
+        "@npm//@angular/core",
+        "@npm//@types/jasmine",
+    ],
+)

src/cdk/testing/event-objects.ts renamed to src/cdk/testing/fake-events/event-objects.ts

@@ -7,5 +7,5 @@ exports_files(["tsconfig-e2e.json"])
 ng_e2e_test_library(
     name = "e2e",
     srcs = glob(["**/*.ts"]),
-    module_name = "@angular/cdk/private/testing/e2e",
+    module_name = "@angular/cdk/testing/private/e2e",
 )

src/cdk/testing/fake-events/index.ts

@@ -6,6 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
+export * from '../fake-events'; // Re-exported for convenince.
 export * from './expect-async-error';
 export * from './wrapped-error-message';
 export * from './mock-ng-zone';

src/cdk/testing/type-in-element.ts renamed to src/cdk/testing/fake-events/type-in-element.ts

@@ -11,6 +11,7 @@ ts_library(
     module_name = "@angular/cdk/testing/protractor",
     deps = [
         "//src/cdk/testing",
+        "//src/cdk/testing/private",
         "@npm//protractor",
     ],
 )

src/cdk/testing/private/BUILD.bazel

@@ -6,10 +6,10 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {ModifierKeys} from '@angular/cdk/testing';
 import {browser, ElementFinder, Key} from 'protractor';
 import {ElementDimensions} from '../element-dimensions';
 import {TestElement, TestKey} from '../test-element';
+import {ModifierKeys} from '../fake-events';
 
 /** Maps the `TestKey` constants to Protractor's `Key` constants. */
 const keyMap = {

src/cdk/private/testing/e2e/BUILD.bazel renamed to src/cdk/testing/private/e2e/BUILD.bazel

@@ -7,9 +7,5 @@
  */
 
 export * from './component-harness';
-export * from './dispatch-events';
-export * from './element-focus';
-export * from './event-objects';
 export * from './harness-environment';
 export * from './test-element';
-export * from './type-in-element';

src/cdk/private/testing/e2e/actions.ts renamed to src/cdk/testing/private/e2e/actions.ts

@@ -7,7 +7,7 @@
  */
 
 import {ElementDimensions} from './element-dimensions';
-import {ModifierKeys} from './event-objects';
+import {ModifierKeys} from './fake-events';
 
 /** An enum of non-text keys that can be used with the `sendKeys` method. */
 // NOTE: This is a separate enum from `@angular/cdk/keycodes` because we don't necessarily want to

src/cdk/private/testing/e2e/asserts.ts renamed to src/cdk/testing/private/e2e/asserts.ts

@@ -12,6 +12,7 @@ ts_library(
     deps = [
         "//src/cdk/keycodes",
         "//src/cdk/testing",
+        "//src/cdk/testing/private",
         "@npm//@angular/core",
         "@npm//rxjs",
     ],