Skip to content

refactor: remove event faking apis from public api #17382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2019

Conversation

crisbeto
Copy link
Member

Moves the event faking APIs into cdk/private/testing in order to avoid exposing them in the public API of cdk/testing.

Resolves COMP-239.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 12, 2019
@crisbeto crisbeto marked this pull request as ready for review October 12, 2019 10:53
@crisbeto crisbeto added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: major This PR is targeted for the next major release labels Oct 12, 2019
@crisbeto crisbeto added this to the 9.0.0 milestone Oct 12, 2019
@crisbeto crisbeto force-pushed the COMP-239/event-faking-apis branch 8 times, most recently from 2cb34b3 to a7f8108 Compare October 14, 2019 21:22
@crisbeto
Copy link
Member Author

@mmalerba @jelbourn @devversion I've reworked it so all the private APIs are in cdk/testing/private and cdk/testing/private/e2e now.

Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems reasonable to me, but @devversion should confirm that with this structure:

  1. @angular/cdk/testing/private and @angular/cdk/testing/private/e2e will not be published to NPM
  2. The imports of the private symbols in @angular/cdk/testing will still work

@devversion
Copy link
Member

This won't work in the release output since cdk/testing/private will not be part of the release output. We could fix that by making it a tertiary entry-point (with bundles etc.), but then cdk/testing/ also needs to import it through the module name (i.e. @angular/cdk/testing/private).

Also, IIRC we chatted about this again in the Slack channel. The solution Jeremy proposed initially seems to work the best without having to create a new published entry-point that contains all private testing utilities.

@crisbeto crisbeto force-pushed the COMP-239/event-faking-apis branch 5 times, most recently from 126c5a3 to 32e6d42 Compare October 17, 2019 20:40
@crisbeto crisbeto force-pushed the COMP-239/event-faking-apis branch 3 times, most recently from c30d3c5 to aa843ba Compare October 17, 2019 21:32
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Oct 17, 2019
@crisbeto crisbeto force-pushed the COMP-239/event-faking-apis branch from aa843ba to 99e4d77 Compare October 20, 2019 07:19
@mmalerba mmalerba force-pushed the COMP-239/event-faking-apis branch from 99e4d77 to 28b04e4 Compare October 22, 2019 18:17
@crisbeto crisbeto force-pushed the COMP-239/event-faking-apis branch 3 times, most recently from b8c8152 to 803144b Compare October 22, 2019 18:26
Moves the event faking APIs into `cdk/private/testing` in order to avoid exposing them in the public API of `cdk/testing`.

Resolves COMP-239.
@crisbeto crisbeto force-pushed the COMP-239/event-faking-apis branch from 803144b to 7365ee5 Compare October 22, 2019 18:38
@mmalerba mmalerba merged commit 3052304 into angular:master Oct 22, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants