-
Notifications
You must be signed in to change notification settings - Fork 6.8k
refactor: remove event faking apis from public api #17382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2cb34b3
to
a7f8108
Compare
@mmalerba @jelbourn @devversion I've reworked it so all the private APIs are in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, seems reasonable to me, but @devversion should confirm that with this structure:
@angular/cdk/testing/private
and@angular/cdk/testing/private/e2e
will not be published to NPM- The imports of the private symbols in
@angular/cdk/testing
will still work
This won't work in the release output since Also, IIRC we chatted about this again in the Slack channel. The solution Jeremy proposed initially seems to work the best without having to create a new published entry-point that contains all private testing utilities. |
126c5a3
to
32e6d42
Compare
c30d3c5
to
aa843ba
Compare
aa843ba
to
99e4d77
Compare
99e4d77
to
28b04e4
Compare
b8c8152
to
803144b
Compare
Moves the event faking APIs into `cdk/private/testing` in order to avoid exposing them in the public API of `cdk/testing`. Resolves COMP-239.
803144b
to
7365ee5
Compare
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Moves the event faking APIs into
cdk/private/testing
in order to avoid exposing them in the public API ofcdk/testing
.Resolves COMP-239.