Skip to content

Commit 85e4a1d

Browse files
devversionjelbourn
authored andcommitted
build: circleci git config being updated too early (#13950)
* Due to the fact that we try to run `git config --global` before CircleCI set up the global Git configuration, the publish task is still broken. This _should_ fix it.
1 parent 2a9e132 commit 85e4a1d

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

.circleci/config.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -215,16 +215,16 @@ jobs:
215215
name: Check whether this job should be skipped.
216216
command: '[[ -n ${CIRCLE_PR_NUMBER} ]] && circleci step halt || true'
217217

218-
# CircleCI has a config setting to enforce SSH for all github connections.
219-
# This is not compatible with our mechanism of using a Personal Access Token
220-
# to publish the build snapshots. In order to fix this, we unset the global option.
221-
- run: git config --global --unset "url.ssh://[email protected]"
222-
223218
- *checkout_code
224219
- *restore_cache
225220
- *yarn_install
226221
- *attach_release_output
227222

223+
# CircleCI has a config setting to enforce SSH for all github connections.
224+
# This is not compatible with our mechanism of using a Personal Access Token
225+
# to publish the build snapshots. In order to fix this, we unset the global option.
226+
- run: git config --global --unset "url.ssh://[email protected]"
227+
228228
- run: ./scripts/circleci/publish-snapshots.sh
229229

230230
- *save_cache

0 commit comments

Comments
 (0)