Skip to content

build: circleci git config being updated too early #13950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2018
Merged

build: circleci git config being updated too early #13950

merged 1 commit into from
Nov 2, 2018

Conversation

devversion
Copy link
Member

  • Due to the fact that we try to run git config --global before CircleCI set up the global Git configuration, the publish task is still broken. This should fix it.

@devversion
build: circleci git config being updated too early
117c854 
* Due to the fact that we try to run `git config --global` before
CircleCI set up the global Git configuration, the publish task is still
broken. This _should_ fix it.
@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Nov 2, 2018
@devversion devversion requested a review from jelbourn as a code owner November 2, 2018 21:57
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 2, 2018
@devversion
Copy link
Member Author

The bazel_build_test job should be fixed with #13949.

jelbourn
jelbourn approved these changes Nov 2, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 2, 2018
@ngbot
Copy link

ngbot bot commented Nov 2, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: bazel_build_test" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@jelbourn jelbourn merged commit 85e4a1d into angular:master Nov 2, 2018
atscott pushed a commit to atscott/components that referenced this pull request Nov 5, 2018
@devversion @atscott
build: circleci git config being updated too early (angular#13950)
ba004e1 
* Due to the fact that we try to run `git config --global` before
CircleCI set up the global Git configuration, the publish task is still
broken. This _should_ fix it.
jelbourn pushed a commit that referenced this pull request Nov 6, 2018
@devversion @jelbourn
build: circleci git config being updated too early (#13950)
3c68217 
* Due to the fact that we try to run `git config --global` before
CircleCI set up the global Git configuration, the publish task is still
broken. This _should_ fix it.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devversion @jelbourn @googlebot