Skip to content

Commit abfb7a2

Browse files
authored
fix(button): don't use divs in button template (#20376)
* fix(button): don't use divs in button template * address feedback
1 parent fd34f35 commit abfb7a2

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

src/material-experimental/mdc-button/button.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
The indicator can't be directly on the button, because MDC uses ::before for high contrast
1010
indication and it can't be on the ripple, because it has a border radius and overflow: hidden.
1111
-->
12-
<div class="mat-mdc-focus-indicator"></div>
12+
<span class="mat-mdc-focus-indicator"></span>
1313

1414
<ng-content select=".material-icons[iconPositionEnd], mat-icon[iconPositionEnd]">
1515
</ng-content>

src/material/button/button.html

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<span class="mat-button-wrapper"><ng-content></ng-content></span>
2-
<div matRipple class="mat-button-ripple"
3-
[class.mat-button-ripple-round]="isRoundButton || isIconButton"
4-
[matRippleDisabled]="_isRippleDisabled()"
5-
[matRippleCentered]="isIconButton"
6-
[matRippleTrigger]="_getHostElement()"></div>
7-
<div class="mat-button-focus-overlay"></div>
2+
<span matRipple class="mat-button-ripple"
3+
[class.mat-button-ripple-round]="isRoundButton || isIconButton"
4+
[matRippleDisabled]="_isRippleDisabled()"
5+
[matRippleCentered]="isIconButton"
6+
[matRippleTrigger]="_getHostElement()"></span>
7+
<span class="mat-button-focus-overlay"></span>

0 commit comments

Comments
 (0)