Skip to content

fix(button): don't use divs in button template #20376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 28, 2020
Merged

fix(button): don't use divs in button template #20376

merged 2 commits into from
Aug 28, 2020

Conversation

mmalerba
Copy link
Contributor

No description provided.

@mmalerba mmalerba added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent G This is is related to a Google internal issue target: patch This PR is targeted for the next patch release labels Aug 20, 2020
@mmalerba mmalerba requested a review from jelbourn August 20, 2020 20:15
@mmalerba mmalerba requested a review from andrewseguin as a code owner August 20, 2020 20:15
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 20, 2020
crisbeto added a commit to crisbeto/material2 that referenced this pull request Aug 22, 2020
@crisbeto
fix(button-toggle): don't use divs inside button template
b56f27e 
Along the same lines as angular#20376. Doesn't use divs inside the button toggle.
This was referenced Aug 22, 2020
Merged
Closed
jelbourn
jelbourn approved these changes Aug 24, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I won't be surprised if this breaks something.

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Aug 24, 2020
@jelbourn jelbourn merged commit abfb7a2 into angular:master Aug 28, 2020
jelbourn pushed a commit that referenced this pull request Aug 28, 2020
@mmalerba @jelbourn
fix(button): don't use divs in button template (#20376)
d307e3e 
* fix(button): don't use divs in button template

* address feedback

(cherry picked from commit abfb7a2)
annieyw pushed a commit to annieyw/components that referenced this pull request Aug 31, 2020
@mmalerba @annieyw
fix(button): don't use divs in button template (angular#20376)
27c029a 
* fix(button): don't use divs in button template

* address feedback
mmalerba added a commit that referenced this pull request Sep 2, 2020
@mmalerba
fix(button): don't use divs in button template (#20376)
ecde050 
* fix(button): don't use divs in button template

* address feedback
wagnermaciel pushed a commit that referenced this pull request Sep 16, 2020
@crisbeto
fix(button-toggle): don't use divs inside button template (#20390)
85e8f34 
Along the same lines as #20376. Doesn't use divs inside the button toggle.
wagnermaciel pushed a commit that referenced this pull request Sep 16, 2020
@crisbeto @wagnermaciel
fix(button-toggle): don't use divs inside button template (#20390)
95e48bb 
Along the same lines as #20376. Doesn't use divs inside the button toggle.

(cherry picked from commit 85e8f34)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zelliott zelliott zelliott left review comments

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin andrewseguin approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mmalerba @jelbourn @zelliott @andrewseguin @googlebot