Skip to content

Commit c5bdab8

Browse files
crisbetojelbourn
authored andcommitted
build: add 404 page to dev app (#14551)
Currently misspelling a URL in the dev app results in a few seconds of staring into a blank screen since Angular just throws an error in the background. These changes add a 404 page to make it easier to figure out what's wrong.
1 parent 26ff7ec commit c5bdab8

File tree

3 files changed

+14
-2
lines changed

3 files changed

+14
-2
lines changed

src/dev-app/dev-app-module.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ import {CheckboxDemo, MatCheckboxDemoNestedChecklist} from './checkbox/checkbox-
2727
import {ChipsDemo} from './chips/chips-demo';
2828
import {ConnectedOverlayDemo} from './connected-overlay/connected-overlay-demo';
2929
import {CustomHeader, CustomHeaderNgContent, DatepickerDemo} from './datepicker/datepicker-demo';
30-
import {DevAppComponent, DevAppHome} from './dev-app';
30+
import {DevAppComponent, DevAppHome, DevApp404} from './dev-app';
3131
import {ContentElementDialog, DialogDemo, IFrameDialog, JazzDialog} from './dialog/dialog-demo';
3232
import {DragAndDropDemo} from './drag-drop/drag-drop-demo';
3333
import {DrawerDemo} from './drawer/drawer-demo';
@@ -99,6 +99,7 @@ import {VirtualScrollDemo} from './virtual-scroll/virtual-scroll-demo';
9999
DatepickerDemo,
100100
DevAppComponent,
101101
DevAppHome,
102+
DevApp404,
102103
DialogDemo,
103104
DragAndDropDemo,
104105
DrawerDemo,

src/dev-app/dev-app.ts

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,3 +110,13 @@ export class DevAppComponent {
110110
`,
111111
})
112112
export class DevAppHome {}
113+
114+
@Component({
115+
template: `
116+
<h1>404</h1>
117+
<p>This page does not exist</p>
118+
<a mat-raised-button routerLink="/">Go back to the home page</a>
119+
`,
120+
host: {'class': 'mat-typography'},
121+
})
122+
export class DevApp404 {}

src/dev-app/routes.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import {CheckboxDemo} from './checkbox/checkbox-demo';
1818
import {ChipsDemo} from './chips/chips-demo';
1919
import {ConnectedOverlayDemo} from './connected-overlay/connected-overlay-demo';
2020
import {DatepickerDemo} from './datepicker/datepicker-demo';
21-
import {DevAppHome} from './dev-app';
21+
import {DevAppHome, DevApp404} from './dev-app';
2222
import {DialogDemo} from './dialog/dialog-demo';
2323
import {DragAndDropDemo} from './drag-drop/drag-drop-demo';
2424
import {DrawerDemo} from './drawer/drawer-demo';
@@ -103,4 +103,5 @@ export const DEV_APP_ROUTES: Routes = [
103103
{path: 'connected-overlay', component: ConnectedOverlayDemo},
104104
{path: 'virtual-scroll', component: VirtualScrollDemo},
105105
{path: 'examples', component: ExamplesPage},
106+
{path: '**', component: DevApp404},
106107
];

0 commit comments

Comments
 (0)