Skip to content

build: add 404 page to dev app #14551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2018
Merged

Conversation

crisbeto
Copy link
Member

Currently misspelling a URL in the dev app results in a few seconds of staring into a blank screen since Angular just throws an error in the background. These changes add a 404 page to make it easier to figure out what's wrong.

Currently misspelling a URL in the dev app results in a few seconds of staring into a blank screen since Angular just throws an error in the background. These changes add a 404 page to make it easier to figure out what's wrong.
@crisbeto crisbeto added pr: merge safe target: patch This PR is targeted for the next patch release labels Dec 17, 2018
@crisbeto crisbeto requested a review from jelbourn as a code owner December 17, 2018 23:11
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 17, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 17, 2018
@jelbourn jelbourn merged commit c5bdab8 into angular:master Dec 18, 2018
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
Currently misspelling a URL in the dev app results in a few seconds of staring into a blank screen since Angular just throws an error in the background. These changes add a 404 page to make it easier to figure out what's wrong.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants