Skip to content

fix(datepicker): toggle should inherit color from mat-form-field through mat-datepicker #10245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2018

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Mar 2, 2018

Also adds docs for color feature.

Fixes #10221

@mmalerba mmalerba added pr: needs review target: major This PR is targeted for the next major release labels Mar 2, 2018
@mmalerba mmalerba added this to the 6.0 milestone Mar 2, 2018
@mmalerba mmalerba requested a review from crisbeto March 2, 2018 19:33
@mmalerba mmalerba requested review from amcdnl and jelbourn as code owners March 2, 2018 19:33
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 2, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Mar 2, 2018
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nit

@Input()
get color(): ThemePalette {
return this._color ||
(this._datepickerInput ? this._datepickerInput ._getThemePalette() : undefined);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an extra space before the question mark and the ._getThemePalette.

@jelbourn jelbourn merged commit 749f2a0 into angular:master Mar 6, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

datepicker: document new features for 6.0.0
4 participants