docs(sidenav): add docs for hasBackdrop
#10287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalerba
added
pr: needs review
target: patch
googlebot
added
the
cla: yes
jelbourn
reviewed
Mar 6, 2018
src/lib/sidenav/sidenav.md
Outdated
| @@ -117,7 +117,15 @@ If no `mode` is specified, `over` is used by default. | |||
|
|
|||
| <!-- example(sidenav-mode) --> | |||
|
|
|||
| `<mat-drawer>` also supports all of these same modes. | |||
| The `over` and `push` sidenav modes show a backdrop by default, while the side mode does not. This | |||
src/lib/sidenav/sidenav.md
Outdated
| @@ -117,7 +117,15 @@ If no `mode` is specified, `over` is used by default. | |||
|
|
|||
| <!-- example(sidenav-mode) --> | |||
|
|
|||
| `<mat-drawer>` also supports all of these same modes. | |||
| The `over` and `push` sidenav modes show a backdrop by default, while the side mode does not. This | |||
| can be customized by setting the `hasBackdrop` property on `mat-sidenav-container`. Setting it to | |||
There was a problem hiding this comment.
You could consolidate these two similar sentence:
Explicitly setting `hasBackdrop` will override the default behavior of the `mode`.
|
comments addressed |
jelbourn
added
pr: lgtm
action: merge
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Mar 7, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10223