Schematic fixes #10388
Schematic fixes #10388
Conversation
googlebot
added
the
cla: yes
schematics/utils/ast.ts
Outdated
| }); | ||
|
|
||
| if (!styles) { | ||
| throw new SchematicsException(`Could not find global styles.ext file.`); |
There was a problem hiding this comment.
Isn't it valid to call your root style file something else entirely? Can we read the first stylesheet from the config? Would it be better to just no-op if we can't find it?
There was a problem hiding this comment.
Well there is just a styles array where this lives which could include other stuff too. They could change it but I find it HIGHLY unlikely. I'll noop more gracefully.
There was a problem hiding this comment.
Yeah, I know if I was making a large app, I wouldn't want to have a file called styles.css because it's too vague, so I'd rename it to something like global-styles.css or browser-reset.css
schematics/utils/ast.ts
Outdated
| const config = getConfig(host); | ||
| const app = getAppFromConfig(config, '0'); | ||
| const styles = app.styles.find(style => { | ||
| const str = style.toString(); |
There was a problem hiding this comment.
const styles = app.styles.find(s => /styles\.(c|le|sc)ss/.test(s));
schematics/shell/index.ts
Outdated
| `<link href="https://fonts.googleapis.com/css?family=Roboto:300,400,500" rel="stylesheet">`); | ||
| addHeadLink(host, | ||
| `<link href="https://fonts.googleapis.com/icon?family=Material+Icons" rel="stylesheet">`); | ||
| addHeadLink(host, ` |
There was a problem hiding this comment.
I generally prefer to not rely on newlines in template strings since it's not immediately obvious that they're intentional and someone might remove it
There was a problem hiding this comment.
Ya, I agree. Got a better alternative? Just /n?
There was a problem hiding this comment.
Yep, just \n is obvious that it's intentional
|
@jelbourn - done. |
jelbourn
added
pr: lgtm
action: merge
* fix(schematics): better formatting on index, insert body margin 0 * fix(schematics): fix wrong mode on init * fix(schemtic): convert == to === * fix(schematic): fix check expression * chore: pr feedback
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Addresses items in #10352
body { margin: 0; }on initial scaffold==to===