fix(checkbox): fix checkbox animation when moved between view containers #10589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
josephperrott
added
pr: lgtm
action: merge
crisbeto
reviewed
Mar 28, 2018
src/lib/checkbox/checkbox.ts
Outdated
|
|
||
| // Remove the animation class to avoid animation when the checkbox is moved between containers | ||
| const animationClass = this._currentAnimationClass; | ||
| setTimeout(() => { |
There was a problem hiding this comment.
This one can run outside the NgZone since it's toggling the class directly on the element.
There was a problem hiding this comment.
Done. This changed the constructor.
tinayuangao
force-pushed
the
checkbox-anim
branch
from
2f9aa63 to
96fc6b5
Compare
tinayuangao
added
the
presubmit failures
josephperrott
pushed a commit
that referenced
this pull request
Jun 28, 2018
victoriaaa234
pushed a commit
that referenced
this pull request
Jul 25, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constructor change
Remove the transition css class after 1s
Fixes #10575