Skip to content

chore(table): clean up demo pages #10669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 19, 2018
Merged

chore(table): clean up demo pages #10669

merged 5 commits into from
Apr 19, 2018

Conversation

andrewseguin
Copy link
Contributor

The main demo page contains too much - reduced to be simpler and added a few more pages for different features

@andrewseguin andrewseguin requested a review from jelbourn as a code owner April 2, 2018 21:02
josephperrott
josephperrott approved these changes Apr 2, 2018
View reviewed changes
src/demo-app/table/custom-table/custom-table.scss
}

.mat-card {
margin: 8px 0;
height: 300px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alphabetical order.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have a rule for css property order, actually

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 4, 2018
@andrewseguin andrewseguin added pr: needs review target: patch This PR is targeted for the next patch release and removed pr: merge safe labels Apr 4, 2018
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Apr 19, 2018
@andrewseguin
Copy link
Contributor Author

Caretaker: Will require BUILD changes, see change 193566542

@andrewseguin andrewseguin added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed pr: merge safe labels Apr 19, 2018
@mmalerba
Copy link
Contributor

@andrewseguin there seems to be an issue with the AOT test

@mmalerba mmalerba removed the action: merge The PR is ready for merge by the caretaker label Apr 19, 2018
@andrewseguin
Copy link
Contributor Author

andrewseguin commented Apr 19, 2018 •
edited
Loading

Thanks, pushed fix

@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Apr 19, 2018
@mmalerba mmalerba merged commit deedebd into angular:master Apr 19, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

@mmalerba mmalerba mmalerba approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andrewseguin @mmalerba @jelbourn @josephperrott @googlebot