fix(material/expansion-panel): handle long text inside panel header title and description #10750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| @@ -29,9 +29,13 @@ | |||
|
|
|||
| .mat-expansion-panel-header-title, | |||
| .mat-expansion-panel-header-description { | |||
| display: flex; | |||
| display: block; | |||
There was a problem hiding this comment.
Should this be inline block, or are we relying on flex to handle the non-blocking?
There was a problem hiding this comment.
We need it to be a block for the ellipsis overflow to work.
josephperrott
added
the
target: patch
josephperrott
added
pr: lgtm
action: merge
|
Just a thought; material-ui expands to fit the text (example: https://codesandbox.io/s/917pm83o5r). Would it be better to follow that practice, rather than ellipsis? |
andrewseguin
added
the
P3
|
nice, thanks a lot! |
crisbeto
force-pushed
the
10744/expansion-header-long-text
branch
from
b384836 to
701e44e
Compare
andrewseguin
removed
the
cla: yes
|
I looked into rebasing this one, but it'll cause a regression of the fix from #12161. |
crisbeto
force-pushed
the
10744/expansion-header-long-text
branch
from
701e44e to
d6de7f2
Compare
crisbeto
changed the title
…nd description Handles long text inside the `mat-panel-title` and `mat-panel-description`. Previously the text would continue wrapping and overflowing the header. Fixes angular#10744.
crisbeto
force-pushed
the
10744/expansion-header-long-text
branch
from
d6de7f2 to
12d4116
Compare
andrewseguin
removed
the
P3
andrewseguin
added
the
merge: caretaker note
mmalerba
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles long text inside the
mat-panel-titleandmat-panel-description. Previously the text would continue wrapping and overflowing the header.Fixes #10744.
Caretaker note (crisbeto): Lots of screenshot diffs, may have to come up with a different approach.