chore: fix test leaking overlay elements #11045
Conversation
Fixes a menu test that wasn't cleaning up properly and was leaking overlay elements into other tests.
googlebot
added
the
cla: yes
| @@ -484,10 +484,11 @@ describe('MatMenu', () => { | |||
| }); | |||
|
|
|||
| it('should default to the "below" and "after" positions', () => { | |||
| overlayContainer.ngOnDestroy(); | |||
There was a problem hiding this comment.
Why does the destroy happen at the beginning of the test? Shouldn't this be in an afterEach?
There was a problem hiding this comment.
We have it the afterEach. This one needs to happen, because we destroy the fixture and create a new one on the line below.
jelbourn
added
pr: lgtm
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes a menu test that wasn't cleaning up properly and was leaking overlay elements into other tests.