Skip to content

fix(paginator): handle negative pageSize and pageIndex correctly #11068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2018

Conversation

crisbeto
Copy link
Member

Doesn't allow for the pageSize or pageIndex of the paginator to be set to negative numbers. It doesn't make sense for them to be negative and allowing it ends up displaying some weird values in the view.

Doesn't allow for the `pageSize` or `pageIndex` of the paginator to be set to negative numbers. It doesn't make sense for them to be negative and allowing it ends up displaying some weird values in the view.
@crisbeto crisbeto requested a review from andrewseguin as a code owner April 29, 2018 14:25
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 29, 2018
@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Apr 30, 2018
@ngbot
Copy link

ngbot bot commented Apr 30, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure missing required label: "target: "
    failure forbidden label detected: pr: needs

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@andrewseguin andrewseguin added pr: lgtm target: patch This PR is targeted for the next patch release and removed pr: needs review labels Apr 30, 2018
@josephperrott josephperrott merged commit 3f5e481 into angular:master May 1, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants