build: include cdk-experimental/dialog in various configs #11891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Jun 22, 2018
src/cdk-experimental/public-api.ts
Outdated
| @@ -8,3 +8,4 @@ | |||
|
|
|||
| export * from './version'; | |||
| export * from '@angular/cdk-experimental/scrolling'; | |||
| export * from '@angular/cdk-experimental/dialog'; | |||
There was a problem hiding this comment.
I think I want to change this to be the other way around- that we don't re-export anything through the root package. It will make the setup in google easier
* Removes the exports of `cdk-experimental/scrolling` from the root `cdk-experimental`. * Adds the dialog package to a handful of configs that didn't have it. Mostly for consistency.
crisbeto
force-pushed
the
experimental-dialog-configs
branch
from
72f644a to
908c90b
Compare
crisbeto
changed the title
|
Changed it so |
josephperrott
added
pr: lgtm
action: merge
victoriaaa234
pushed a commit
that referenced
this pull request
Jul 25, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cdk-experimental/scrollingfrom the rootcdk-experimental.