fix(sidenav): remove margin from content instead of setting zero #11986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
josephperrott
added
pr: lgtm
action: merge
|
cc @vikerman |
In SSR scenarious, the sidenav always gets `0` for DOM measurements, causing it to always set a zero margin to the sidenav content. This prevents an app from setting a custom margin so that the sidenav appears correctly after SSR.
jelbourn
force-pushed
the
sidenav-no-zero-margin
branch
from
69f7cd1 to
1b86c32
Compare
josephperrott
pushed a commit
that referenced
this pull request
Jun 29, 2018
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jul 4, 2018
Fixes the sidenav going into an infinite change detection loop when using the `autosize` option. Initially this was fixed in angular#11231, but it got reintroduced in angular#11986 where we started comparing `0` against `null` which always evaluates to true. Fixes angular#11215.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jul 4, 2018
Fixes the sidenav going into an infinite change detection loop when using the `autosize` option. Initially this was fixed in angular#11231, but it got reintroduced in angular#11986 where we started comparing `0` against `null` which always evaluates to true. Fixes angular#11215.
victoriaaa234
pushed a commit
that referenced
this pull request
Jul 25, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SSR scenarios, the sidenav always gets
0for DOM measurements,causing it to always set a zero margin to the sidenav content. This
prevents an app from setting a custom margin so that the sidenav appears
correctly after SSR.