Skip to content

refactor(table): remove redundant constructors #12301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2018

Conversation

crisbeto
Copy link
Member

Removes some redundant constructors that were added as a workaround for a compiler issue that's been fixed since 6.0.

Removes some redundant constructors that were added as a workaround for a compiler issue that's been fixed since 6.0.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jul 20, 2018
@crisbeto crisbeto requested a review from andrewseguin as a code owner July 20, 2018 20:15
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 20, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Did the tree do this too?

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 20, 2018
@crisbeto
Copy link
Member Author

Doesn't look like it. The tree has some derived classes, but they all add something in the constructors.

@mmalerba mmalerba merged commit c2190e4 into angular:master Jul 26, 2018
mmalerba pushed a commit that referenced this pull request Jul 30, 2018
Removes some redundant constructors that were added as a workaround for a compiler issue that's been fixed since 6.0.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants