feat(button-toggle): align with 2018 material design spec #12443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
approved these changes
Jul 30, 2018
jelbourn
added
pr: lgtm
action: merge
This was referenced Aug 2, 2018
josephperrott
removed
the
action: merge
|
@crisbeto looks like there is a lint error on this one |
crisbeto
force-pushed
the
button-toggle-new-spec
branch
from
44051d2 to
400ecf1
Compare
|
I've sorted out the lint warning. |
jelbourn
added
the
P2
crisbeto
force-pushed
the
button-toggle-new-spec
branch
from
400ecf1 to
b30c37b
Compare
jelbourn
reviewed
Sep 21, 2018
| set appearance(value: MatButtonToggleAppearance) { | ||
| this._appearance = value; | ||
| } | ||
| private _appearance: MatButtonToggleAppearance; |
There was a problem hiding this comment.
Could you add docs for this in a follow-up PR?
There was a problem hiding this comment.
Sure, I've put it on my list.
Aligns the button toggle component with the latest Material design spec.
crisbeto
force-pushed
the
button-toggle-new-spec
branch
from
b30c37b to
015a666
Compare
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Sep 28, 2018
Fixes a stylelint failure that was introduced by a PR which was submitted before the line breaks rule was introduced (angular#12443).
jelbourn
pushed a commit
that referenced
this pull request
Sep 28, 2018
Fixes a stylelint failure that was introduced by a PR which was submitted before the line breaks rule was introduced (#12443).
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Oct 3, 2018
As discussed in angular#12443, these changes add some docs and a live example for the button toggle `appearance`.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Oct 5, 2018
As discussed in angular#12443, these changes add some docs and a live example for the button toggle `appearance`.
vivian-hu-zz
pushed a commit
that referenced
this pull request
Oct 5, 2018
As discussed in #12443, these changes add some docs and a live example for the button toggle `appearance`.
roboshoes
pushed a commit
to roboshoes/material2
that referenced
this pull request
Oct 23, 2018
Fixes a stylelint failure that was introduced by a PR which was submitted before the line breaks rule was introduced (angular#12443).
roboshoes
pushed a commit
to roboshoes/material2
that referenced
this pull request
Oct 23, 2018
As discussed in angular#12443, these changes add some docs and a live example for the button toggle `appearance`.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligns the button toggle component with the latest Material design spec.