Skip to content

chore: allow for scss imports from node_modules #12475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2018

Conversation

josephperrott
Copy link
Member

No description provided.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 1, 2018
@josephperrott josephperrott added target: master only and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Aug 1, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 1, 2018
@josephperrott josephperrott added pr: merge safe and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Aug 1, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 1, 2018
@devversion devversion added action: merge The PR is ready for merge by the caretaker pr: lgtm labels Aug 1, 2018
@devversion
Copy link
Member

devversion commented Aug 1, 2018

Should we also consider adding the include_paths to the Bazel rules?

https://github.com/bazelbuild/rules_sass

I know that will involve a lot of work, so just asking 😄

@jelbourn
Copy link
Member

jelbourn commented Aug 1, 2018

@devversion
Copy link
Member

Yeah, but adding them to every sass_binary rule could take a while. That's what I meant.

@jelbourn
Copy link
Member

jelbourn commented Aug 1, 2018

Ah, yeah. If we wanted to add them everywhere we'd want to make a wrapper for sass_binary and use that everywhere

@josephperrott josephperrott merged commit 3357e70 into angular:master Aug 7, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
@josephperrott josephperrott deleted the sass-imports branch March 20, 2020 22:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants