fix(menu): menu content data being cleared when lazy-loaded content is reused between nested triggers #12476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Aug 1, 2018
src/lib/menu/menu-trigger.ts
Outdated
| @@ -243,11 +243,18 @@ export class MatMenuTrigger implements AfterContentInit, OnDestroy { | |||
| menu._resetAnimation(); | |||
|
|
|||
| if (menu.lazyContent) { | |||
| menu.lazyContent._attached.pipe(take(1)).subscribe(() => console.log('re-attached')); | |||
There was a problem hiding this comment.
ops, I forgot about that one. It's removed.
…s reused between nested triggers Fixes an issue where a nested menu with lazy-loaded that is reused between multiple triggers will clear its content once an alternate trigger is hovered. The issue comes from the fact that we wait for the exit animation to finish before we detach the content, which ends up detaching the content of the new trigger as well. Fixes angular#12467.
crisbeto
force-pushed
the
12467/menu-data-reusable-menu
branch
from
302c9f8 to
d673388
Compare
jelbourn
pushed a commit
that referenced
this pull request
Aug 7, 2018
…s reused between nested triggers (#12476) Fixes an issue where a nested menu with lazy-loaded that is reused between multiple triggers will clear its content once an alternate trigger is hovered. The issue comes from the fact that we wait for the exit animation to finish before we detach the content, which ends up detaching the content of the new trigger as well. Fixes #12467.
jelbourn
pushed a commit
that referenced
this pull request
Aug 7, 2018
…s reused between nested triggers (#12476) Fixes an issue where a nested menu with lazy-loaded that is reused between multiple triggers will clear its content once an alternate trigger is hovered. The issue comes from the fact that we wait for the exit animation to finish before we detach the content, which ends up detaching the content of the new trigger as well. Fixes #12467.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where a nested menu with lazy-loaded that is reused between multiple triggers will clear its content once an alternate trigger is hovered. The issue comes from the fact that we wait for the exit animation to finish before we detach the content, which ends up detaching the content of the new trigger as well.
Note: I spent some time on trying to get a proper test that covers this issue, but I wasn't able to get something that fails when we expect it to. The issue is very closely tied to the animations module and the async animations which are being flushed synchronously in tests.
Fixes #12467.