Skip to content

chore(select): fix flaky positioning test #12496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2018
Merged

chore(select): fix flaky positioning test #12496

merged 1 commit into from
Aug 2, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 2, 2018

Fixes a flaky test that is failing on iOS.

@crisbeto
chore(select): fix flaky positioning test
279ce73 
Fixes a flaky test that is failing on iOS.
@crisbeto crisbeto added the in progress This issue is currently in progress label Aug 2, 2018
@crisbeto crisbeto self-assigned this Aug 2, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 2, 2018
@crisbeto crisbeto added pr: merge safe and removed in progress This issue is currently in progress labels Aug 2, 2018
@crisbeto crisbeto assigned jelbourn and unassigned crisbeto Aug 2, 2018
jelbourn
jelbourn approved these changes Aug 2, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 2, 2018
@jelbourn jelbourn merged commit 674ebcd into angular:master Aug 2, 2018
josephperrott pushed a commit to josephperrott/components that referenced this pull request Aug 6, 2018
@crisbeto @josephperrott
chore(select): fix flaky positioning test (angular#12496)
e11509e 
Fixes a flaky test that is failing on iOS.
josephperrott pushed a commit to josephperrott/components that referenced this pull request Aug 6, 2018
@crisbeto @josephperrott
chore(select): fix flaky positioning test (angular#12496)
c525c8a 
Fixes a flaky test that is failing on iOS.
josephperrott pushed a commit to josephperrott/components that referenced this pull request Aug 6, 2018
@crisbeto @josephperrott
chore(select): fix flaky positioning test (angular#12496)
07a4015 
Fixes a flaky test that is failing on iOS.
jelbourn pushed a commit to jelbourn/components that referenced this pull request Aug 7, 2018
@crisbeto @jelbourn
chore(select): fix flaky positioning test (angular#12496)
cd42793 
Fixes a flaky test that is failing on iOS.
jelbourn pushed a commit that referenced this pull request Aug 7, 2018
@crisbeto @jelbourn
chore(select): fix flaky positioning test (#12496)
e0a3b47 
Fixes a flaky test that is failing on iOS.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @jelbourn @googlebot