Skip to content

docs(schematics): add grammar fixes to schematics guide #12532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2018
Merged

docs(schematics): add grammar fixes to schematics guide #12532

merged 1 commit into from
Aug 7, 2018

Conversation

amritaramnauth
Copy link

Fixes minor grammar issues in schematics guide.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 5, 2018
crisbeto
crisbeto approved these changes Aug 5, 2018
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm docs This issue is related to documentation action: merge The PR is ready for merge by the caretaker labels Aug 5, 2018
jelbourn
jelbourn approved these changes Aug 6, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added target: patch This PR is targeted for the next patch release and removed target: master only labels Aug 6, 2018
@josephperrott josephperrott merged commit b5d4bb0 into angular:master Aug 7, 2018
@amritaramnauth amritaramnauth deleted the docs-schematics branch August 7, 2018 21:25
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto crisbeto approved these changes

@amcdnl amcdnl Awaiting requested review from amcdnl

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@amritaramnauth @jelbourn @crisbeto @googlebot @josephperrott