refactor(schematics): detect package version from node modules

[devversion]

No longer hard codes the Angular Material and Angular version name in the schematics.

• For the CDK and Material version, the schematics will look for the according VERSION object in the node modules.

• For the Angular version, we look for the @angular/core version in the package.json and try to use that. Falling back to the the 0.0.0-NG placeholder that specifies the required Angular version for Material and the CDK.

[jelbourn]

I actually don't want to read the Angular version from the package.json. the way it is now, we have the flexibility to publish a range that is more broad than what we're installing. The required version should always be an explicit choice.

[devversion]

Are we talking just about the version for the @angular/animations package? From my perspective, it makes sense to align the @angular/animations version with the @angular/core version.

Otherwise the peer dependencies of @angular/animations can be wrong, and the developer would need to manually change the version afterwards, which kind of should be part of the schematic.

I'm fine just switching the 0.0.0-NG placeholder fallback to be the default for the @angular/animations, if you mean that.

[jelbourn]

I think I misunderstood your description. Would it be accurate to say

Use version of @angular/animations matching @angular/core instead of @angular/material

?

[devversion]

Sorry, the PR actually has two changes and I probably wasn't too clear in the description.

• The @angular/animations version will match @angular/core version instead of being hard-coded to a loose version range. If the @angular/core version couldn't be determined --> we fall back to the minimum required Angular version for Material (0.0.0-NG placeholder)

• The @angular/material and @angular/cdk package versions will be set to the version that comes with the schematics. Meaning that we just look for the currently installed (in the node modules) VERSION and write that to the package.json.

This is needed because when running: ng add @angular/material, the CLI just installs @angular/material (without saving in the package.json). So we need to save some version to the package.json.

[jelbourn]

LGTM

I should have just looked at the code instead of only reading the description

[devversion]

haha, my fault, sorry 😄 I felt like this was clear enough, but apparently it was too difficult to cover both two things in a short but clear way.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}