Skip to content

feat(button): align with 2018 material design spec #12537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2018
Merged

feat(button): align with 2018 material design spec #12537

merged 1 commit into from
Sep 5, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 5, 2018 •
edited
Loading

Aligns the button component with the latest Material design spec.
before
after

@crisbeto crisbeto added the target: major This PR is targeted for the next major release label Aug 5, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 5, 2018
jelbourn
jelbourn approved these changes Aug 6, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I suspect this be be the most screenshot diffs we've ever done.

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Aug 6, 2018
josephperrott
josephperrott reviewed Aug 6, 2018
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the styling changes that you have in this PR, we should take this chance to not set the default color of FABs as primary and instead allow a non-themed FAB.

src/lib/button/_button-base.scss Outdated
padding: $mat-button-padding;
border-radius: $mat-button-border-radius;
letter-spacing: 0.08929em;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Letter spacing should be handled in the typography correct?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least at the moment we don't have letter spacing as a part of the config. I can add it in when I get to doing the typography changes.

@josephperrott josephperrott removed the action: merge The PR is ready for merge by the caretaker label Aug 6, 2018
@jelbourn
Copy link
Member

jelbourn commented Aug 7, 2018

I'm iffy about making fabs not default to accent

@josephperrott
Copy link
Member

@jelbourn Is your concern with the amount of change this will bring? Or a bad default state?

@jelbourn
Copy link
Member

jelbourn commented Aug 7, 2018

@josephperrott mainly that it's too breaking of a change, but also that I do suspect most people won't want a default (gray) FAB.

@crisbeto
Copy link
Member Author

crisbeto commented Aug 7, 2018

I've moved out the letter spacing into the typography mixin and will hold off on switching the default color for FABs @josephperrott.

@josephperrott
Copy link
Member

@jelbourn okay, works for me. Lets leave it as the default for now and we can look in the future at allowing for a provider to defines the default for an app.

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Aug 7, 2018
@ngbot
Copy link

ngbot bot commented Aug 7, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "continuous-integration/travis-ci/pr" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@jelbourn jelbourn added the P2 The issue is important to a large percentage of users, with a workaround label Aug 14, 2018
@josephperrott
Copy link
Member

Removing merge ready as we plan to rework this PR a bit.

@josephperrott josephperrott removed the action: merge The PR is ready for merge by the caretaker label Aug 24, 2018
@crisbeto
feat(button): align with 2018 material design spec
51bd101 
Aligns the button component with the latest Material design spec.
@crisbeto
Copy link
Member Author

I've reworked the PR as discussed. The screenshot above has been updated as well. Mark as merge ready again.

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Aug 26, 2018
@jelbourn jelbourn merged commit 4ddbde9 into angular:master Sep 5, 2018
jelbourn added a commit to jelbourn/components that referenced this pull request Sep 11, 2018
@jelbourn
Revert "feat(button): align with 2018 material design spec (angular#1…
257c183 
…2537)"

This reverts commit 4ddbde9.
jelbourn added a commit that referenced this pull request Sep 11, 2018
@jelbourn
Revert "feat(button): align with 2018 material design spec (#12537)" (#…
5718975 
…13080)

This reverts commit 4ddbde9.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Sep 11, 2018
@crisbeto
feat(button): align with 2018 material design spec
f1b7e32 
Aligns the button component with the latest Material design spec.

This includes the changes from angular#12537 and angular#13011.
@crisbeto crisbeto mentioned this pull request Sep 11, 2018
Merged
crisbeto added a commit to crisbeto/material2 that referenced this pull request Sep 18, 2018
@crisbeto
feat(button): align with 2018 material design spec
adee126 
Aligns the button component with the latest Material design spec.

This includes the changes from angular#12537 and angular#13011.
mmalerba pushed a commit that referenced this pull request Sep 19, 2018
@crisbeto @mmalerba
feat(button): align with 2018 material design spec (#13083)
79801e0 
Aligns the button component with the latest Material design spec.

This includes the changes from #12537 and #13011.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott left review comments

@jelbourn jelbourn jelbourn approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @josephperrott @googlebot