fix(tabs): animation running after initialization #12549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Due to angular#12229, the selected tab of a tab-group will incorrectly animate after initialization. This happens because the `MatTab` component by default assigns the `origin` to `null`. Right now the check does only handle `undefined` properly. Fixes angular#12455
devversion
added
regression
googlebot
added
the
cla: yes
jelbourn
approved these changes
Aug 6, 2018
josephperrott
pushed a commit
that referenced
this pull request
Aug 7, 2018
josephperrott
pushed a commit
that referenced
this pull request
Aug 7, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to fix(tabs): reposition tab body on direction change #12229, the selected tab of a tab-group will incorrectly animate after initialization. This happens because the
MatTabcomponent by default assigns theorigintonull.Right now the check does only handle
undefinedproperly.See: https://stackblitz.com/edit/angular-zwcr1a
Fixes #12455