test: fix slide-toggle e2e failures #12699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
approved these changes
Aug 16, 2018
devversion
added
pr: lgtm
action: merge
crisbeto
force-pushed
the
slide-toggle-e2e-timeout
branch
from
3d6f19b to
28c6bd2
Compare
Fixes some e2e failures in the slide toggle after the new design got in. The tests expect the ripples to go away at some point, however we introduced a permanent ripple.
crisbeto
force-pushed
the
slide-toggle-e2e-timeout
branch
from
28c6bd2 to
69edf0a
Compare
mmalerba
pushed a commit
that referenced
this pull request
Aug 20, 2018
Fixes some e2e failures in the slide toggle after the new design got in. The tests expect the ripples to go away at some point, however we introduced a permanent ripple.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Aug 27, 2018
Fixes a timeout in the radio button e2e tests, after the new design changes got in. The tests expect there to be no ripples, but the new design introduced a permanent ripple in each button. This is along the same lines as angular#12699.
jelbourn
pushed a commit
that referenced
this pull request
Aug 27, 2018
Fixes a timeout in the radio button e2e tests, after the new design changes got in. The tests expect there to be no ripples, but the new design introduced a permanent ripple in each button. This is along the same lines as #12699.
jelbourn
pushed a commit
that referenced
this pull request
Aug 29, 2018
Fixes a timeout in the radio button e2e tests, after the new design changes got in. The tests expect there to be no ripples, but the new design introduced a permanent ripple in each button. This is along the same lines as #12699.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some e2e failures in the slide toggle after the new design got in. The tests expect the ripples to go away at some point, however we introduced a permanent ripple.