fix: explictly declare types for mixin base classes #12876
Conversation
jelbourn
requested review from
amcdnl,
andrewseguin,
devversion and
josephperrott
as code owners
googlebot
added
the
cla: yes
|
|
||
| export const _MatButtonMixinBase: |
There was a problem hiding this comment.
These mixins are getting more and more inconvenient to consume :/
There was a problem hiding this comment.
I'm going to file an issue with TypeScript to see if they can be smarter about keeping the original import paths
There was a problem hiding this comment.
LGTM. (sample of the generated import() statements for later reference: here)
We could probably also fix this by moving the typings/ directories on directory up (in the release output). But this is not really that predictable than just being explicit.
src/cdk/collections/selection.ts
Outdated
| @@ -39,7 +39,7 @@ export class SelectionModel<T> { | |||
| /** | |||
| * Event emitted when the value has changed. | |||
| * @deprecated Use `changed` instead. | |||
| * @breaking-change 8.0.0 To be changed to `changed` | |||
| * @deletion-target 8.0.0 To be changed to `changed` | |||
There was a problem hiding this comment.
Shouldn't this stay as @breaking-change?
As of TypeScript 2.9, tsc will inline imports for inferred types with
the `import("...")` syntax. However, this inlining happens *after*
`paths` are resolved. This means that in places where we import from
`@angular/material/core` in source end up having relative paths (e.g.
`../core/common-behaviors/index`) in the generated d.ts files. These
relative import paths become incorrect when moved into our package
structure, breaking downstream apps.
jelbourn
force-pushed
the
arrghghghghgh
branch
from
300b2ce to
3ad85f8
Compare
Removes a workaround that was initially introduced to get angular#12182 through. The root issue has been resolved in angular#12876.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
As of TypeScript 2.9, tsc will inline imports for inferred types with
the
import("...")syntax. However, this inlining happens afterpathsare resolved. This means that in places where we import from@angular/material/corein source end up having relative paths (e.g.../core/common-behaviors/index) in the generated d.ts files. Theserelative import paths become incorrect when moved into our package
structure, breaking downstream apps.
cc @IgorMinar, @devversion FYI