fix(slider): update value on mousedown instead of click #13020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the slider updates its value on the `click` event or when the user drags for at least one pixel. This looks weird, because the thumb label shows up as soon as the user puts down their pointer, but the value updates only if they lift it or they start dragging. There will always be a value update, because the user can't move their pointer outside the element without either lifting it or triggering the drag event. Furthermore, the native `input type="range"` updates its value on `mousedown` as well and doing so makes the slider feel snappier.
googlebot
added
the
cla: yes
|
This would probably have to be a major change since it affects the timing of events in a way that's likely to break tests and maybe even actual code |
mmalerba
added
pr: lgtm
action: merge
crisbeto
added
target: patch
josephperrott
pushed a commit
that referenced
this pull request
Oct 19, 2018
josephperrott
pushed a commit
that referenced
this pull request
Oct 19, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the slider updates its value on the
clickevent or when the user drags for at least one pixel. This looks weird, because the thumb label shows up as soon as the user puts down their pointer, but the value updates only if they lift it or they start dragging. There will always be a value update, because the user can't move their pointer outside the element without either lifting it or triggering the drag event.Furthermore, the native
input type="range"updates its value onmousedownas well and doing so makes the slider feel snappier.