fix(drag-drop): emitting incorrect index for horizontal list in rtl #13274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the wrong index being emitted if the list is horizontal in an RTL layout.
googlebot
added
the
cla: yes
jelbourn
reviewed
Sep 24, 2018
| // The rest of the logic still stands no matter what orientation we're in, however | ||
| // we need to invert the array when determining the index. | ||
| const items = this.orientation === 'horizontal' && this._dir && this._dir.value === 'rtl' ? | ||
| this._positionCache.items.slice().reverse() : this._positionCache.items; |
There was a problem hiding this comment.
How often is getItemIndex called? I'm wondering if slice().reverse() might get expensive for large lists
There was a problem hiding this comment.
It's called twice when an item is dropped to figure out its old index and the new one. I don't imagine it getting too expensive, unless we're dealing with a massive array.
jelbourn
added
pr: lgtm
action: merge
roboshoes
pushed a commit
to roboshoes/material2
that referenced
this pull request
Oct 23, 2018
…ngular#13274) Fixes the wrong index being emitted if the list is horizontal in an RTL layout.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the wrong index being emitted if the list is horizontal in an RTL layout.