fix(checkbox): clear tabindex from host element #13308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we forward the tabindex from the host element to the underlying input, however we leave behind the tabindex on the host, which means that consumers can end up with two layers of focusable elements.
crisbeto
requested review from
devversion,
jelbourn and
josephperrott
as code owners
googlebot
added
the
cla: yes
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Sep 25, 2018
Along the same lines as angular#13308. Currently we forward the `tabindex` from the host to the underlying `input`, however we never clear the `tabindex` from the host, which means that we end up with two layers of focusable elements.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Sep 25, 2018
Along the same lines as angular#13308. Currently we forward the `tabindex` from the host to the underlying `input`, however we never clear the `tabindex` from the host, which means that we end up with two layers of focusable elements.
jelbourn
added
Accessibility
|
Caretaker note: I have a hunch this will have some e2e test failures |
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Sep 26, 2018
Along the same lines as angular#13311 and angular#13308. Clears the `tabindex` from the radio button host element so we don't end up with multiple tab stops.
jelbourn
pushed a commit
that referenced
this pull request
Sep 27, 2018
vivian-hu-zz
pushed a commit
that referenced
this pull request
Oct 2, 2018
Along the same lines as #13308. Currently we forward the `tabindex` from the host to the underlying `input`, however we never clear the `tabindex` from the host, which means that we end up with two layers of focusable elements.
roboshoes
pushed a commit
to roboshoes/material2
that referenced
this pull request
Oct 23, 2018
Along the same lines as angular#13311 and angular#13308. Clears the `tabindex` from the radio button host element so we don't end up with multiple tab stops.
roboshoes
pushed a commit
to roboshoes/material2
that referenced
this pull request
Oct 23, 2018
Currently we forward the tabindex from the host element to the underlying input, however we leave behind the tabindex on the host, which means that consumers can end up with two layers of focusable elements.
roboshoes
pushed a commit
to roboshoes/material2
that referenced
this pull request
Oct 23, 2018
Along the same lines as angular#13308. Currently we forward the `tabindex` from the host to the underlying `input`, however we never clear the `tabindex` from the host, which means that we end up with two layers of focusable elements.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we forward the tabindex from the host element to the underlying input, however we leave behind the tabindex on the host, which means that consumers can end up with two layers of focusable elements.