Skip to content

feat(schematics): CDK support for ng add #13319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 27, 2018

Conversation

devversion
Copy link
Member

  • Introduces support for ng add @angular/cdk. Note that this currently just sets up the package.json but is necessary because otherwise the CLI will complain about the ng-add schematic not being available.
  • Upgrades Bazel workspace rules in favor of removing Bazel manual-copying workarounds for the schematics. This also allows us to switch over to fine-grained dependencies in a follow-up (making it consistent with angular/angular).

@devversion devversion added pr: merge safe target: major This PR is targeted for the next major release labels Sep 26, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 26, 2018
@devversion devversion force-pushed the feat/cdk-ng-add-support branch 3 times, most recently from ef97561 to 759804d Compare September 26, 2018 16:43
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion force-pushed the feat/cdk-ng-add-support branch 2 times, most recently from c90539f to a5d0453 Compare September 26, 2018 18:28
@devversion devversion added the blocked This issue is blocked by some external factor, such as a prerequisite PR label Sep 26, 2018
@devversion devversion force-pushed the feat/cdk-ng-add-support branch from a5d0453 to 2a45c19 Compare September 27, 2018 07:28
* Introduces support for `ng add @angular/cdk`. Note that this currently just sets up the `package.json` but is necessary because otherwise the CLI will complain about the `ng-add` schematic not being available.
* Upgrades Bazel workspace rules in favor of removing Bazel manual-copying workarounds for the schematics. This also allows us to switch over to fine-grained dependencies in a follow-up (making it consistent with angular/angular).
@devversion devversion force-pushed the feat/cdk-ng-add-support branch from 2a45c19 to 56753a3 Compare September 27, 2018 07:51
@devversion devversion force-pushed the feat/cdk-ng-add-support branch from 56753a3 to 52f2120 Compare September 27, 2018 07:53
@devversion devversion removed the blocked This issue is blocked by some external factor, such as a prerequisite PR label Sep 27, 2018
@devversion
Copy link
Member Author

@jelbourn Should be ready now. Please have another look.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 27, 2018
@jelbourn jelbourn merged commit ac3f8c4 into angular:master Sep 27, 2018
@devversion devversion deleted the feat/cdk-ng-add-support branch September 27, 2018 21:03
@Splaktar Splaktar changed the title feat(schematics): support for ng add feat(schematics): CDK support for ng add Oct 5, 2018
roboshoes pushed a commit to roboshoes/material2 that referenced this pull request Oct 23, 2018
* Introduces support for `ng add @angular/cdk`. Note that this currently just sets up the `package.json` but is necessary because otherwise the CLI will complain about the `ng-add` schematic not being available.
* Upgrades Bazel workspace rules in favor of removing Bazel manual-copying workarounds for the schematics. This also allows us to switch over to fine-grained dependencies in a follow-up (making it consistent with angular/angular).
* Use fine grained dependencies in schematics bazel rules
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants