Skip to content

build: switch to yarn #13362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 5, 2018
Merged

Conversation

devversion
Copy link
Member

Switches away from package-lock.json to yarn.lock because the NPM lock files are not platform independent and change based on optionalDependencies that can be installed.

Since the lock file always changes after NPM install on CircleCI, the cache key will be always different, and therefore never available for the next commit that runs on the CI.

Note: This is based on top of #13359 and should be merged once #13359 has been merged.

@devversion devversion added pr: merge safe target: major This PR is targeted for the next major release labels Sep 29, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 29, 2018
@devversion devversion force-pushed the build/switch-to-yarn branch 3 times, most recently from 25b71c2 to 57243b2 Compare October 1, 2018 15:55
@devversion
Copy link
Member Author

This should be ready now. The e2e failure is unrelated and should be fixed with #13376

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

In preparation for merging this, we need to make sure everyone has yarn set up

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 2, 2018
@ngbot
Copy link

ngbot bot commented Oct 2, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "continuous-integration/travis-ci/pr" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@devversion devversion force-pushed the build/switch-to-yarn branch 2 times, most recently from 4b92dff to aac3eea Compare October 4, 2018 15:42
@jelbourn
Copy link
Member

jelbourn commented Oct 4, 2018

@devversion could you rebase?

@devversion devversion force-pushed the build/switch-to-yarn branch 3 times, most recently from 18725c3 to bb527a6 Compare October 4, 2018 19:28
@devversion
Copy link
Member Author

@jelbourn Should be good now. Let's wait for CircleCI to finish.

@devversion devversion removed the action: merge The PR is ready for merge by the caretaker label Oct 5, 2018
@ngbot
Copy link

ngbot bot commented Oct 5, 2018

Hi @devversion! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@devversion devversion force-pushed the build/switch-to-yarn branch from bb527a6 to 882dc9a Compare October 5, 2018 19:29
@devversion devversion added action: merge The PR is ready for merge by the caretaker and removed action: merge The PR is ready for merge by the caretaker labels Oct 5, 2018
@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Oct 5, 2018
@devversion
Copy link
Member Author

This one is good to go now.

@vivian-hu-zz vivian-hu-zz merged commit da63c6f into angular:master Oct 5, 2018
roboshoes pushed a commit to roboshoes/material2 that referenced this pull request Oct 23, 2018
* build: switch to yarn

* Use more recent version of Yarn
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants