-
Notifications
You must be signed in to change notification settings - Fork 6.8k
build: switch to yarn #13362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: switch to yarn #13362
Conversation
25b71c2
to
57243b2
Compare
This should be ready now. The e2e failure is unrelated and should be fixed with #13376 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In preparation for merging this, we need to make sure everyone has yarn
set up
4b92dff
to
aac3eea
Compare
@devversion could you rebase? |
18725c3
to
bb527a6
Compare
@jelbourn Should be good now. Let's wait for CircleCI to finish. |
Hi @devversion! This PR has merge conflicts due to recent upstream merges. |
bb527a6
to
882dc9a
Compare
This one is good to go now. |
* build: switch to yarn * Use more recent version of Yarn
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Switches away from
package-lock.json
toyarn.lock
because the NPM lock files are not platform independent and change based onoptionalDependencies
that can be installed.Since the lock file always changes after NPM install on CircleCI, the cache key will be always different, and therefore never available for the next commit that runs on the CI.
Note: This is based on top of #13359 and should be merged once #13359 has been merged.