build(schematics): version placeholders not replaced #13688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
jelbourn
reviewed
Oct 24, 2018
| @@ -48,16 +48,16 @@ export function composeRelease(buildPackage: BuildPackage) { | |||
| copyFiles(packagesDir, 'README.md', releasePath); | |||
| copyFiles(sourceDir, 'package.json', releasePath); | |||
|
|
|||
| if (buildPackage.hasSchematics) { | |||
There was a problem hiding this comment.
This should have a comment like "This must happen before..."
There was a problem hiding this comment.
Done. I've made it a bit more "generic" because hasSchematics is not specific to the Material schematics.
* Since we copy the schematics after the version placeholders have been inlined, the version range that uses the NG version placeholder is not replaced properly.
This is not problematic because by default we determine the NG version based on the installed `@angular/core` version.
```
addPackageToPackageJson(host, '@angular/animations',
ngCoreVersionTag || requiredAngularVersionRange);
```
ilease enter the commit message for your changes. Lines starting
devversion
force-pushed
the
build/schematics-version-placeholders
branch
from
834095a to
9acb263
Compare
jelbourn
added
pr: lgtm
action: merge
atscott
pushed a commit
to atscott/components
that referenced
this pull request
Nov 5, 2018
Since we copy the schematics after the version placeholders have been inlined, the version range that uses the NG version placeholder is not replaced properly.
This is not problematic because by default we determine the NG version based on the installed `@angular/core` version.
```
addPackageToPackageJson(host, '@angular/animations',
ngCoreVersionTag || requiredAngularVersionRange);
```
jelbourn
pushed a commit
that referenced
this pull request
Nov 6, 2018
Since we copy the schematics after the version placeholders have been inlined, the version range that uses the NG version placeholder is not replaced properly.
This is not problematic because by default we determine the NG version based on the installed `@angular/core` version.
```
addPackageToPackageJson(host, '@angular/animations',
ngCoreVersionTag || requiredAngularVersionRange);
```
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an issue right now, because by default we determine the NG version based on the installed
@angular/coreversion.