docs: expand example that removes value accessor provider #13860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
docs
googlebot
added
the
cla: yes
devversion
reviewed
Oct 30, 2018
| { | ||
| provide: NG_VALUE_ACCESSOR, | ||
| useExisting: forwardRef(() => MatFormFieldControl), | ||
| multi: true, |
There was a problem hiding this comment.
Is the indentation intentional here?
There was a problem hiding this comment.
Looks like I took this from somewhere that was indented with tabs, instead of spaces.
There was a problem hiding this comment.
Should we show the provider commented out or something? To make it easier to notice that they're supposed to remove this
In the form field guide, we instruct people to remove the `NG_VALUE_ACCESSOR` provider and replace it with injecting the `NgControl`, however it's not very explicit and is easy to miss. These changes expand the example a bit in an effort to make it harder to miss. Fixes angular#8158.
crisbeto
force-pushed
the
8158/value-accessor-docs-exapnd
branch
from
c1bd5d5 to
f6b179e
Compare
mmalerba
approved these changes
Oct 30, 2018
vivian-hu-zz
pushed a commit
that referenced
this pull request
Nov 12, 2018
In the form field guide, we instruct people to remove the `NG_VALUE_ACCESSOR` provider and replace it with injecting the `NgControl`, however it's not very explicit and is easy to miss. These changes expand the example a bit in an effort to make it harder to miss. Fixes #8158.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the form field guide, we instruct people to remove the
NG_VALUE_ACCESSORprovider and replace it with injecting theNgControl, however it's not very explicit and is easy to miss. These changes expand the example a bit in an effort to make it harder to miss.Fixes #8158.