Skip to content

fix(form-field): superfluous whitespace when compiled with bazel #13911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2019

Conversation

devversion
Copy link
Member

  • Fixes that the form-field does not render properly when being compiled through Bazel. This is because the whitespace is being preserved due to Bazel not minifying HTML files like we do with Gulp.

@devversion devversion added the target: patch This PR is targeted for the next patch release label Oct 31, 2018
@devversion devversion requested a review from mmalerba as a code owner October 31, 2018 18:16
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 31, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 31, 2018
@devversion devversion force-pushed the fix/form-field-whitespace-bazel branch from 80a4906 to 07b9c39 Compare November 10, 2018 10:12
@mmalerba mmalerba added aaa and removed aaa labels Apr 25, 2019
* Fixes that the form-field does not render properly when being compiled through Bazel. This is because the whitespace is being preserved due to Bazel not minifying HTML files like we do with Gulp.
@devversion devversion force-pushed the fix/form-field-whitespace-bazel branch from 07b9c39 to b31487c Compare May 14, 2019 16:48
@devversion devversion added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Jun 25, 2019
@devversion
Copy link
Member Author

Marking as P3 because it is ultimately a prerequisite for building & shipping Material with Bazel.

@mmalerba
Copy link
Contributor

Shouldn't we just minify the HTML files instead?

@devversion
Copy link
Member Author

devversion commented Jun 25, 2019

Ideally we would, but for this one it's generally an anti-pattern to rely on the minifier to remove the superfluous whitespace by joining multiple lines into a single one.

Also I'm not sure if there is even logic that allows us to do that because the resource inlining feature of @angular/compiler-cli does not provide an API to put in the minified files w/ bazel.

@jelbourn jelbourn added P2 The issue is important to a large percentage of users, with a workaround and removed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Jun 25, 2019
@jelbourn jelbourn merged commit cf11ed2 into angular:master Jul 16, 2019
jelbourn pushed a commit that referenced this pull request Jul 16, 2019
)

Fixes that the form-field does not render properly when being compiled through Bazel. This is because the whitespace is being preserved due to Bazel not minifying HTML files like we do with Gulp.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants