-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(form-field): superfluous whitespace when compiled with bazel #13911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(form-field): superfluous whitespace when compiled with bazel #13911
Conversation
devversion
commented
Oct 31, 2018
- Fixes that the form-field does not render properly when being compiled through Bazel. This is because the whitespace is being preserved due to Bazel not minifying HTML files like we do with Gulp.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
80a4906
to
07b9c39
Compare
* Fixes that the form-field does not render properly when being compiled through Bazel. This is because the whitespace is being preserved due to Bazel not minifying HTML files like we do with Gulp.
07b9c39
to
b31487c
Compare
Marking as P3 because it is ultimately a prerequisite for building & shipping Material with Bazel. |
Shouldn't we just minify the HTML files instead? |
Ideally we would, but for this one it's generally an anti-pattern to rely on the minifier to remove the superfluous whitespace by joining multiple lines into a single one. Also I'm not sure if there is even logic that allows us to do that because the resource inlining feature of |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |