fix(ng-update): do not fail if @schematics/angular version is outdated #13929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Currently the `ng update` could potentially fail if the version of `@schematics/angular` is outdated on the given project. We should avoid to depend on `@schematics/angular` for the `ng-update` schematic.
* No longer fails if the workspace configuration could not be found. It's very uncommon that someone tries to update a CLI project that still uses `.angular-cli.json` because:
1) The CLI version for the project doesn't support `ng update` with custom downstream migrations
2) In case the developer runs a different CLI version for _that_ outdated project, the CLI technically does run for an invalid project.
Even though, this is a rare case, it doesn't hurt not throwing if the workspace configuration couldn't be found when running `ng update`.
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
atscott
pushed a commit
to atscott/components
that referenced
this pull request
Nov 5, 2018
angular#13929) * Currently the `ng update` could potentially fail if the version of `@schematics/angular` is outdated on the given project. We should avoid to depend on `@schematics/angular` for the `ng-update` schematic. * No longer fails if the workspace configuration could not be found. It's very uncommon that someone tries to update a CLI project that still uses `.angular-cli.json` because: 1) The CLI version for the project doesn't support `ng update` with custom downstream migrations 2) In case the developer runs a different CLI version for _that_ outdated project, the CLI technically does run for an invalid project. Even though, this is a rare case, it doesn't hurt not throwing if the workspace configuration couldn't be found when running `ng update`.
jelbourn
pushed a commit
that referenced
this pull request
Nov 6, 2018
#13929) * Currently the `ng update` could potentially fail if the version of `@schematics/angular` is outdated on the given project. We should avoid to depend on `@schematics/angular` for the `ng-update` schematic. * No longer fails if the workspace configuration could not be found. It's very uncommon that someone tries to update a CLI project that still uses `.angular-cli.json` because: 1) The CLI version for the project doesn't support `ng update` with custom downstream migrations 2) In case the developer runs a different CLI version for _that_ outdated project, the CLI technically does run for an invalid project. Even though, this is a rare case, it doesn't hurt not throwing if the workspace configuration couldn't be found when running `ng update`.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
ng updatecould potentially fail if the version of@schematics/angularis outdated on the given project. We should avoid to depend on@schematics/angularfor theng-updateschematic.No longer fails if the workspace configuration could not be found. It's very uncommon that someone tries to update a CLI project that still uses
.angular-cli.jsonbecause:ng updatewith custom downstream migrationsEven though, this is a rare case, it doesn't hurt not throwing if the workspace configuration couldn't be found when running
ng update.