-
Notifications
You must be signed in to change notification settings - Fork 6.8k
build: build material-examples with bazel #13932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: build material-examples with bazel #13932
Conversation
It actually passed locally for me because I had the I will need to play more with it.. I'm considering using a |
I think we would have to use a |
Sounds good. Just interesting to see how we could run Gulp. Just having the logic as a single JS file is probably easier. |
Right- it's probably easiest to move it to a standalone script |
cdaf565
to
57839ff
Compare
@jelbourn I've finished the switch to a Bazel genrule. As mentioned on Slack, there were various things that slowed down this process because there were a few things I had to work around in favor of Windows. This should be good now. Note that I didn't clean up too much of the existing AST parsing logic.. I've simplified the templating though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This includes a `genrule` to create the generated `ExampleModule`
This includes a `genrule` to create the generated `ExampleModule`
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.