Skip to content

build: build material-examples with bazel #13932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 2, 2018

Conversation

devversion
Copy link
Member

No description provided.

@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Nov 1, 2018
@devversion devversion requested a review from jelbourn as a code owner November 1, 2018 19:37
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 1, 2018
@devversion
Copy link
Member Author

It actually passed locally for me because I had the example-module.ts generated. This is not the case on the CI, so there are failures.

I will need to play more with it.. I'm considering using a genrule to build the file, but doesn't sound too good in the long-term.

@devversion devversion added in progress This issue is currently in progress and removed in progress labels Nov 1, 2018
@jelbourn
Copy link
Member

jelbourn commented Nov 1, 2018

I think we would have to use a genrule because we really are generating a source file. It's pretty much exactly what genrule is meant for, even if it's usually discouraged.

@devversion
Copy link
Member Author

devversion commented Nov 1, 2018

Sounds good. Just interesting to see how we could run Gulp. Just having the logic as a single JS file is probably easier.

@jelbourn
Copy link
Member

jelbourn commented Nov 1, 2018

Right- it's probably easiest to move it to a standalone script

@devversion devversion force-pushed the build/build-examples-w-bazel branch from cdaf565 to 57839ff Compare November 2, 2018 20:19
@devversion
Copy link
Member Author

@jelbourn I've finished the switch to a Bazel genrule. As mentioned on Slack, there were various things that slowed down this process because there were a few things I had to work around in favor of Windows.

This should be good now. Note that I didn't clean up too much of the existing AST parsing logic.. I've simplified the templating though.

@devversion devversion removed the in progress This issue is currently in progress label Nov 2, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 2, 2018
@jelbourn jelbourn merged commit c64503e into angular:master Nov 2, 2018
atscott pushed a commit to atscott/components that referenced this pull request Nov 5, 2018
This includes a `genrule` to create the generated `ExampleModule`
jelbourn pushed a commit that referenced this pull request Nov 6, 2018
This includes a `genrule` to create the generated `ExampleModule`
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants