Skip to content

build: enable size plugin from angular robot #14025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

We only measure the CDK and Material for now. We can revisit checking other packages as well in the future. First, we should figure out whether the size plugin works for us.

@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Nov 7, 2018
@devversion devversion requested a review from jelbourn as a code owner November 7, 2018 14:22
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 7, 2018
@devversion devversion force-pushed the build/use-size-plugin-angular-robot branch from 669e35e to 6c22eb5 Compare November 7, 2018 14:41
@devversion devversion force-pushed the build/use-size-plugin-angular-robot branch from 6c22eb5 to f83e63e Compare November 7, 2018 15:17
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 7, 2018
@vivian-hu-zz vivian-hu-zz merged commit f6bfcff into angular:master Nov 7, 2018
vivian-hu-zz pushed a commit that referenced this pull request Nov 12, 2018
* build: enable size plugin from angular robot

* Improve comment
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants