chore(stage-release) allow selecting prerelease labels #14070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
devversion
force-pushed
the
chore/release-stage-prerelease-labels
branch
from
733b932 to
65318e4
Compare
Implements the functionality to select a pre-release label (as discussed in: angular#13621 (comment))
devversion
force-pushed
the
chore/release-stage-prerelease-labels
branch
from
65318e4 to
afcc27d
Compare
jelbourn
reviewed
Nov 10, 2018
|
|
||
| if (!prereleaseLabel) { | ||
| return [ALPHA_CHOICE, BETA_CHOICE, RC_CHOICE]; | ||
| } else if (prereleaseLabel === 'alpha') { |
There was a problem hiding this comment.
An alpha could go to another alpha. Or is that captured in another code path?
There was a problem hiding this comment.
Yeah, considering you are already on an alpha, you can either:
- Bump the pre-release number
- Change the pre-release label (to
betaorrc) - Or make a stable release (removing the pre-release suffix)
So, that should cover all possible scenarios.
jelbourn
added
pr: lgtm
action: merge
josephperrott
pushed a commit
that referenced
this pull request
Nov 19, 2018
Implements the functionality to select a pre-release label (as discussed in: #13621 (comment))
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the functionality to select a pre-release label (as discussed in: #13621 (comment))