Skip to content

docs(autocomplete): simple grammatical issue #14073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 10, 2018
Merged

docs(autocomplete): simple grammatical issue #14073

merged 2 commits into from
Nov 10, 2018

Conversation

JWTappert
Copy link
Contributor

docs (autocomplete.md): simple grammatical error fix

Change 'an' to 'a' before mat-option because how it is currently is passive voice misuse.

Justin Tappert added 2 commits November 9, 2018 14:49
Docs: Simple grammatical error fix
237f641 
docs (autocomplete.md): simple grammatical error fix

Change 'an' to 'a' before `mat-option` because how it is currently is passive voice misuse.
Merge pull request #1 from JWTappert/autocomplete-docs-fix
7f5d08f 
Docs: Simple grammatical error fix
@JWTappert JWTappert requested a review from crisbeto as a code owner November 9, 2018 23:10
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 9, 2018
crisbeto
crisbeto approved these changes Nov 9, 2018
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm docs This issue is related to documentation action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Nov 9, 2018
@vivian-hu-zz vivian-hu-zz merged commit 10cb578 into angular:master Nov 10, 2018
vivian-hu-zz pushed a commit that referenced this pull request Nov 12, 2018
Docs: Simple grammatical error fix (#14073)
b4f44ed 
docs (autocomplete.md): simple grammatical error fix

Change 'an' to 'a' before `mat-option` because how it is currently is passive voice misuse.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JWTappert @crisbeto @googlebot @vivian-hu-zz