fix(material/tabs): focus wrapping back to selected label when using shift + tab #14194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
Accessibility
googlebot
added
the
cla: yes
crisbeto
added
the
P3
crisbeto
force-pushed
the
tabs-shift-tab
branch
from
c1747ca to
73aeab4
Compare
crisbeto
force-pushed
the
tabs-shift-tab
branch
from
73aeab4 to
20e733e
Compare
andrewseguin
added
lgtm
action: merge
andrewseguin
removed
the
cla: yes
|
I tried rebasing this, but a lot of our tests fail with a "changed after checked" error. We might have to figure out a different way to do this. |
…shift + tab Currently the `tabindex` of each of the tab labels is determined by the selected index. This means that if the user tabbed into the header, pressed the right arrow and then pressed shift + tab, their focus would end up on the selected tab. These changes switch to basing the `tabindex` on the focused index which is tied both to the selected index and the user's keyboard navigation.
crisbeto
force-pushed
the
tabs-shift-tab
branch
from
20e733e to
03d29b5
Compare
crisbeto
changed the title
crisbeto
added a commit
that referenced
this pull request
Mar 27, 2022
…shift + tab (#14194) Currently the `tabindex` of each of the tab labels is determined by the selected index. This means that if the user tabbed into the header, pressed the right arrow and then pressed shift + tab, their focus would end up on the selected tab. These changes switch to basing the `tabindex` on the focused index which is tied both to the selected index and the user's keyboard navigation. (cherry picked from commit b9bfaee)
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Mar 31, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`13.3.1` -> `13.3.2`](https://renovatebot.com/diffs/npm/@angular%2fcdk/13.3.1/13.3.2) | | [@angular/material](https://github.com/angular/components) | dependencies | patch | [`13.3.1` -> `13.3.2`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/13.3.1/13.3.2) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v13.3.2`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1332-flannel-flamingo-2022-03-30) [Compare Source](angular/components@13.3.1...13.3.2) ##### cdk | Commit | Type | Description | | -- | -- | -- | | [48968719fc](angular/components@4896871) | fix | **a11y:** live announcer promise never resolved if new announcement comes in ([#​24700](angular/components#24700)) | | [e9734a9c66](angular/components@e9734a9) | fix | **testing:** entering negative number values not working with reactive forms ([#​24656](angular/components#24656)) | ##### material | Commit | Type | Description | | -- | -- | -- | | [c677f11ed8](angular/components@c677f11) | fix | **button-toggle:** ripples not clipping correctly in safari ([#​12311](angular/components#12311)) | | [20af3e7c9d](angular/components@20af3e7) | fix | **chips:** ripple not clipped on safari ([#​21495](angular/components#21495)) | | [d04e7c9b69](angular/components@d04e7c9) | fix | **core:** unable to override tag selectors inside .mat-typography ([#​14617](angular/components#14617)) | | [9490a31641](angular/components@9490a31) | fix | **list:** not working correctly when list item is used as a button ([#​13617](angular/components#13617)) | | [b07ae4ccc4](angular/components@b07ae4c) | fix | **menu:** clicks on disabled item closing the menu ([#​19183](angular/components#19183)) | | [e85777712a](angular/components@e857777) | fix | **radio:** set tabindex based on selected state ([#​18081](angular/components#18081)) | | [7f274dc96f](angular/components@7f274dc) | fix | **snack-bar:** ensure that the snack bar always runs inside the NgZone ([#​24611](angular/components#24611)) | | [a5aa87502b](angular/components@a5aa875) | fix | **tabs:** focus wrapping back to selected label when using shift + tab ([#​14194](angular/components#14194)) | | [04f4937b75](angular/components@04f4937) | fix | **tabs:** update tab state when active tab is swapped out ([#​24164](angular/components#24164)) | ##### material-experimental | Commit | Type | Description | | -- | -- | -- | | [a704913d2b](angular/components@a704913) | fix | **mdc-button:** extended fab touch target not covering entire button ([#​24322](angular/components#24322)) | | [23e7b8e6c1](angular/components@23e7b8e) | fix | **mdc-chips:** make it easier to customize chip typography ([#​24632](angular/components#24632)) | | [518022288b](angular/components@5180222) | fix | **mdc-chips:** Mirror aria-describedby to matChipInput ([#​24551](angular/components#24551)) | | [9497b02f8b](angular/components@9497b02) | fix | **mdc-slider:** update layout when container resizes ([#​24648](angular/components#24648)) | | [e5c025dff4](angular/components@e5c025d) | fix | **mdc-slider:** use passive event listeners ([#​24675](angular/components#24675)) | #### Special Thanks Artur Androsovych, ByzantineFailure, David Gonzalez, Dilyorbek, Kristiyan Kostadinov, Naveen, Paul Gschwendtner, Raí Siqueira, Shivam Sethi, Wagner Maciel and Zach Arend <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <[email protected]> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1275 Reviewed-by: 6543 <[email protected]> Co-authored-by: Calciumdibromid Bot <[email protected]> Co-committed-by: Calciumdibromid Bot <[email protected]>
forsti0506
pushed a commit
to forsti0506/components
that referenced
this pull request
Apr 3, 2022
…shift + tab (angular#14194) Currently the `tabindex` of each of the tab labels is determined by the selected index. This means that if the user tabbed into the header, pressed the right arrow and then pressed shift + tab, their focus would end up on the selected tab. These changes switch to basing the `tabindex` on the focused index which is tied both to the selected index and the user's keyboard navigation.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
tabindexof each of the tab labels is determined by the selected index. This means that if the user tabbed into the header, pressed the right arrow and then pressed shift + tab, their focus would end up on the selected tab. These changes switch to basing thetabindexon the focused index which is tied both to the selected index and the user's keyboard navigation.