Skip to content

chore: update issue templates #14338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 4, 2018
Merged

chore: update issue templates #14338

merged 2 commits into from
Dec 4, 2018

Conversation

josephperrott
Copy link
Member

No description provided.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 30, 2018
@josephperrott josephperrott added target: patch This PR is targeted for the next patch release pr: merge safe labels Nov 30, 2018
jelbourn
jelbourn reviewed Dec 4, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's with the three feature/proposal files?

.github/ISSUE_TEMPLATE/bug.md Outdated
StackBlitz starter: https://goo.gl/wwnhMV<br/>


#### What is the use-case or motivation for changing an existing behavior?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should eliminate this question from the bug template

@josephperrott
Copy link
Member Author

@jelbourn The multiple files created was automatic by github. I am not really sure why.

jelbourn
jelbourn approved these changes Dec 4, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 4, 2018
@ngbot
Copy link

ngbot bot commented Dec 4, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: tests_saucelabs" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mmalerba mmalerba merged commit a0bcd81 into master Dec 4, 2018
@mmalerba mmalerba deleted the josephperrott-patch-1 branch December 10, 2018 22:20
mmalerba pushed a commit that referenced this pull request Dec 10, 2018
@josephperrott @mmalerba
chore: update issue templates (#14338)
d7c70b1
josephperrott added a commit to josephperrott/components that referenced this pull request Jan 14, 2019
@josephperrott
chore: update issue templates (angular#14338)
618b7b2
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@josephperrott @jelbourn @googlebot @mmalerba