-
Notifications
You must be signed in to change notification settings - Fork 6.8k
chore: improve type safety in breakpoint observer #14356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve type safety in breakpoint observer #14356
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I get the following error when trying to presubmit this:
|
@mmalerba I will have a look. Let's remove merge ready in the meantime. |
42849cb
to
988c756
Compare
@mmalerba I think I've fixed that. Could you re-run the presubmit if you find some time? Thanks! |
@devversion could you rebase this? |
639e98c
to
d2a44a1
Compare
@jelbourn Done. I was also able to remove another cast to any since we now use a TypeScript |
d2a44a1
to
5e9bcee
Compare
f066809
to
0b0bd6d
Compare
* Fixes a workaround where we cast the MediaQueryList event listener to any because TypeScript didn't have proper types before TS 3.1.
0b0bd6d
to
13bbc4f
Compare
* Fixes a workaround where we cast the MediaQueryList event listener to any because TypeScript didn't have proper types before TS 3.1. (cherry picked from commit 0f47b7a)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes a workaround where we cast the MediaQueryList event listener to any because TypeScript didn't have proper types before TS 3.1.