Skip to content

build: create dev-app deploy output in separate directory #14373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2018
Merged

build: create dev-app deploy output in separate directory #14373

merged 1 commit into from
Dec 3, 2018

Conversation

devversion
Copy link
Member

  • This fixes that serve:devapp does not work after building the deploy output of the dev-app (e.g. when deploying to firebase)

@devversion
build: create dev-app deploy output in separate directory
67c2765 
* This fixes that `serve:devapp` does not work after building the deploy output of the `dev-app` (e.g. when deploying to firebase)
@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Dec 3, 2018
@devversion devversion requested a review from jelbourn as a code owner December 3, 2018 21:26
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 3, 2018
jelbourn
jelbourn approved these changes Dec 3, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 3, 2018
@mmalerba mmalerba merged commit 1e96b01 into angular:master Dec 3, 2018
mmalerba pushed a commit that referenced this pull request Dec 10, 2018
@devversion @mmalerba
build: create dev-app deploy output in separate directory (#14373)
84b1b5c 
* This fixes that `serve:devapp` does not work after building the deploy output of the `dev-app` (e.g. when deploying to firebase)
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
@devversion @josephperrott
build: create dev-app deploy output in separate directory (angular#14373
6662081 
)

* This fixes that `serve:devapp` does not work after building the deploy output of the `dev-app` (e.g. when deploying to firebase)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devversion @jelbourn @googlebot @mmalerba