Skip to content

chore: tweak wording for changelog message in stage-release script #14374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2018
Merged

chore: tweak wording for changelog message in stage-release script #14374

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tools/release/stage-release.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,8 @@ class StageReleaseTask {
console.log();
console.log(green(` ✓ Updated the changelog in ` +
`"${bold(CHANGELOG_FILE_NAME)}"`));
console.log(yellow(` ⚠ You can also make other unrelated modifications. After the ` +
`changes have been made, just continue here.`));
console.log(yellow(` ⚠ Please review CHANGELOG.md and ensure that the log contains only ` +
`changes that apply to the public library release. When done, proceed to the prompt below.`));
console.log();

const {shouldContinue} = await prompt<{shouldContinue: boolean}>({
Expand Down Expand Up @@ -175,7 +175,7 @@ class StageReleaseTask {
/** Updates the version of the project package.json and writes the changes to disk. */
private updatePackageJsonVersion(newVersionName: string) {
const newPackageJson = {...this.packageJson, version: newVersionName};
writeFileSync(this.packageJsonPath, JSON.stringify(newPackageJson, null, 2));
writeFileSync(this.packageJsonPath, JSON.stringify(newPackageJson, null, 2) + '\n');
}

/** Verifies that the latest commit of the current branch is passing all Github statuses. */
Expand Down